Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-04-03] [Snyk] Security upgrade electron from 22.3.3 to 22.3.4 #16479

Closed
melvin-bot bot opened this issue Mar 24, 2023 · 13 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Not a priority

Comments

@melvin-bot
Copy link

melvin-bot bot commented Mar 24, 2023

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • package.json
    • package-lock.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Issue Breaking Change Exploit Maturity
high severity Use After Free
SNYK-JS-ELECTRON-3369913
No No Known Exploit

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0184c812953fd69a34
  • Upwork Job ID: 1639298758199308288
  • Last Price Increase: 2023-03-24
@melvin-bot melvin-bot bot added Internal Requires API changes or must be handled by Expensify staff Weekly KSv2 labels Mar 24, 2023
@MelvinBot
Copy link

This is a Snyk issue. Snyk is a tool that automatically tracks our repositories' dependencies and reports associated security vulnerabilities. It also automatically create PRs to fix these vulnerabilities.

    C+: Please follow these steps to test the linked PR before running through the reviewer checklist:
    - [ ] The first step is to understand the PR: what dependency is it upgrading, for which vulnerability, how it impacts our product & end users.
    - [ ] If the issue is not worth fixing, please add your reasoning in the issue and have the internal engineer review it.
    - [ ] Check the change log (which should be included in the PR description) to see all changes. We want to identify any breaking changes. If it is a minor version bump, it's unlikely that there are any breaking changes. 
    - [ ] Test our feature(s) that make use of this package. If it does not work, we should understand what broke it. It is also a good idea to check our main flows to make sure they are not broken that you can add in the checklist screenshots/videos.

@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~0184c812953fd69a34

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Mar 24, 2023
@MelvinBot
Copy link

Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane (Internal)

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 27, 2023
@melvin-bot melvin-bot bot changed the title [Snyk] Security upgrade electron from 22.3.3 to 22.3.4 [HOLD for payment 2023-04-03] [Snyk] Security upgrade electron from 22.3.3 to 22.3.4 Mar 27, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 27, 2023
@MelvinBot
Copy link

Reviewing label has been removed, please complete the "BugZero Checklist".

@MelvinBot
Copy link

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.89-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-04-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Apr 3, 2023
@MelvinBot
Copy link

@sobitneupane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Apr 6, 2023
@MelvinBot
Copy link

@sobitneupane 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

1 similar comment
@MelvinBot
Copy link

@sobitneupane 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@MelvinBot
Copy link

@sobitneupane 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@MelvinBot
Copy link

@sobitneupane 10 days overdue. Is anyone even seeing these? Hello?

@melvin-bot melvin-bot bot removed the Daily KSv2 label Apr 19, 2023
@MelvinBot
Copy link

This issue has not been updated in over 14 days. @sobitneupane eroding to Weekly issue.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Overdue labels Apr 19, 2023
@melvin-bot melvin-bot bot removed the Weekly KSv2 label May 12, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented May 12, 2023

This issue has not been updated in over 15 days. @sobitneupane eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label May 12, 2023
@melvin-bot melvin-bot bot closed this as completed Jul 24, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Jul 24, 2023

@sobitneupane, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Not a priority
Projects
None yet
Development

No branches or pull requests

2 participants