Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LHN - Default offline avatar and lines instead of spinner are displayed when logging into account #16495

Closed
6 tasks done
kbecciv opened this issue Mar 24, 2023 · 11 comments
Closed
6 tasks done
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Mar 24, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Log in any account

Expected Result:

The page is loading successfully

Actual Result:

Default offline avatar and lines instead of spinner are displayed when logging into account

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.89.0

Reproducible in staging?: Yes

Reproducible in production?: NO

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

image (27)

Bug5991522_Recording__4005.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Mar 24, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@aimane-chnaif
Copy link
Contributor

This is not a bug but intentional from #12698
cc: @roryabraham @shawnborton

@thienlnam
Copy link
Contributor

Yes agreed, this looks intentional

@kbecciv Could we make sure to get test rail steps updated for this?

@thienlnam thienlnam added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Mar 25, 2023
@kbecciv
Copy link
Author

kbecciv commented Mar 25, 2023

@mvtglobally @isagoico Can you please update TR? 🙏

@melvin-bot melvin-bot bot added the Overdue label Mar 27, 2023
@MelvinBot
Copy link

@thienlnam Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@thienlnam
Copy link
Contributor

Assigning you to add this on your radar @isagoico

I've added the test steps from the PR that added this below if that makes it easier:

  1. Sign out if you are signed in
  2. Sign in back to the app
  3. Verify a skeleton is showing while loading the app data

@melvin-bot melvin-bot bot removed the Overdue label Mar 29, 2023
@isagoico
Copy link

@kbecciv @thienlnam Thanks for bringing this into my radar! added steps 2 and 3 to verify this behavior to this TCs:

@aimane-chnaif
Copy link
Contributor

@roryabraham @shawnborton can you please help verify updated TR?

@thienlnam
Copy link
Contributor

Looks great, thank you!

@MelvinBot
Copy link

@thienlnam Be sure to fill out the Contact List!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants