[HOLD for payment 2023-04-10] [$1000] [Regression] Request Money - Amount field not auto focused if suddenly loose focus

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #16394

Action Performed:

1. Launch expensify app
2. Login with any account
3. Tap on the FAB button -> Send money
4. Enter numbers
5. Click outside of numpad
6. Enter numbers

Expected Result:

Autofocus Amount field if suddenly loose focus

Actual Result:

Amount field not auto focused if suddenly loose focus

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.89.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5992450_16394_Desktop.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01dbf046ada3294608
• Upwork Job ID: 1640296677002747904
• Last Price Increase: 2023-03-27

[MelvinBot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[luacmartins]

@mountiny @0xmiroslav @narefyev91 since you worked on #16394. Tapping outside the input doesn't allow for further inputs

[mountiny]

Thanks for the bump here, I will take this one on with @narefyev91 again. Changes to this page open a can of worms sorry

[0xmiros]

@mountiny @0xmiroslav @narefyev91 since you worked on #16394. Tapping outside the input doesn't allow for further inputs

yup that's what I was thinking of but solution of just fixing mWeb side went ahead

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01dbf046ada3294608

[MelvinBot]

Current assignee @sonialiap is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Current assignee @0xmiroslav is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Current assignee @mountiny is eligible for the External assigner, not assigning anyone new.

[narefyev91]

I'm Nikolay from Callstack - and i will take a look on this one

[MelvinBot]

📣 @narefyev91 You have been assigned to this job by @mountiny!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

@0xmiroslav sorry it wasnt clear from you comment on the PR, your suggestion seemed to introduce a different regression.

Let's try to properly investigate this page and get the best cross platform solution, I truest in @0xmiroslav and @narefyev91 skills here to get to the best solution together 🤝 thanks 🙇

[0xmiros]

sorry it wasnt clear from you comment on the PR, your suggestion seemed to introduce a #16394 (comment) regression

yes I knew that so that's why I didn't persist to use my approach.
We should find out way of fixing both issues on web/desktop:

• clicking on any area don't lose focus (alternative is to use similar approach what we did in mWeb, so listen keydown event and manually focus but not sure I follow that approach)
• input numbers should be selectable and cursor should be moveable as normal

[narefyev91]

@mountiny @0xmiroslav As a workaround seems we need to have custom event handler to detect onMouseDown event and only preventDefault() if we click on main wrapper, but not on input (to allow user to move cursor)

    /**
     * Listens for mouse down event and applies the action
     *
     * @param {Object} e
     */
    handleMouseDown(e) {
        if (e.target.nodeName !== 'DIV') { return; }
        e.preventDefault();
    }

Screen.Recording.2023-03-27.at.14.52.49.mov

[mountiny]

Currency selector will still work fine?

[narefyev91]

@mountiny yup

Screen.Recording.2023-03-27.at.15.01.24.mov

[mountiny]

Nice, curious for @0xmiroslav thoughts!

Thanks!

[0xmiros]

It seems work but as @narefyev91 said, it's a workaround. Any chance of finding better solutions?

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.93-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix loose focus for Web/Desktop #16673

If no regressions arise, payment will be issued on 2023-04-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@0xmiroslav / @mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@0xmiroslav / @mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@0xmiroslav / @mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sonialiap] Determine if we should create a regression test for this bug.
• [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

@0xmiroslav would you be able to help with the Checklist please? Then we can pay out

[0xmiros]

The PR that introduced the bug has been identified. Link to the PR:

This issue existed from the beginning but we missed web desktop case while fixing mWeb issue on #16394

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

#15855 (comment)

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

This is already in checklist. I ran the tests on all platforms & verified they passed on: ... so no need further discussion I think.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

I think Test Steps in PR can be used for regression test steps.

[mountiny]

Thank you! I think Sonia is ooo so I will ask someone to help with this.

[mountiny]

@sonialiap we should pay $1000 to @0xmiroslav and we should be all set

[Christinadobrzyn]

Helping with payment:

Looks like this job is eligible for the speed bonus.
Upwork job - https://www.upwork.com/ab/applicants/1640296677002747904/job-details

@narefyev91 can you please provide your Upwork profile so I can hire you for this job?
@0xmiroslav I submitted a request to hire you for the job, let me know when you accept and I'll pay.

[0xmiros]

@Christinadobrzyn I am only the one for upwork payment. @narefyev91 is a callstack member.

[Christinadobrzyn]

Ah thank you for confirming @0xmiroslav!

Submitted Test Rail regression test here - https://github.com/Expensify/Expensify/issues/276043

Paid $1000 + $500 speed bonus to @0xmiroslav

Closing this GH

[hayata-suenaga]

I'm coming to this issue from another issue issue.

The event.preventDefault(); was added in the the PR to fix this issue. However, the original issue doesn't seem to be a problem. Isn't it an expected behavior that the text input looses focus if you click outside of it?

[hayata-suenaga]

decided to go with this fix