[HOLD for payment 2023-05-29] [$1000] Room name not showing in desktop notification

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Log in with user A in desktop
2. Receive a notification from any room

Expected Result:

Room name to show in notification

Actual Result:

Room name not shown

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.90-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679913165835669

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01472822975187e111
• Upwork Job ID: 1658098308413186048
• Last Price Increase: 2023-05-15

[MelvinBot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[joekaufmanexpensify]

Reproduced on desktop!

[MelvinBot]

Current assignee @Julesssss is eligible for the Engineering assigner, not assigning anyone new.

[joekaufmanexpensify]

@jules, assuming you want to keep this one internal?

[Julesssss]

Yeah, for now.

[joekaufmanexpensify]

Sounds good!

[MelvinBot]

@Julesssss @joekaufmanexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[MelvinBot]

@Julesssss @joekaufmanexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[joekaufmanexpensify]

Defer to @Julesssss on whether we're close to a solution here.

[Julesssss]

This is held on other notification issues. Reducing the priority, but I can pick up soon.

[MelvinBot]

@Julesssss @joekaufmanexpensify this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[Julesssss]

This is actually a new feature, so I'm removing the label. I don't think this breaks WAQ personally, but will get this done.

[MelvinBot]

Current assignee @joekaufmanexpensify is eligible for the NewFeature assigner, not assigning anyone new.

[melvin-bot]

📣 @hoangzinh You have been assigned to this job by @Julesssss!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[hoangzinh]

Discussing on slack for the notification title here
https://expensify.slack.com/archives/C01GTK53T8Q/p1684258926118529

[joekaufmanexpensify]

PR is WIP.

[hoangzinh]

@s77rt @Julesssss PR is ready for reviewing #19053. Thanks

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.16-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Show Room name in Desktop notification title if message is come from a chat room #19053

If no regressions arise, payment will be issued on 2023-05-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[joekaufmanexpensify]

No BZ checklist here as this is a new feature. Further, we don't currently pay speed bonuses for new feature issues. So we need to make the following payments here:

• @hoangzinh $1,000 for PR.
• @s77rt $1,000 for C+ review.

[joekaufmanexpensify]

@s77rt offer sent for $1,000!

[joekaufmanexpensify]

@hoangzinh offer sent for $1,000!

[melvin-bot]

Triggered auto assignment to @jliexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[joekaufmanexpensify]

Adding additional assignee as I'm OOO next week (until June 5th). All that's left here is to issue the two above payments on 2023-05-29!

[hoangzinh]

I accepted the offer. Thanks @joekaufmanexpensify

[hoangzinh]

Bump for payout.

[jliexpensify]

Thanks for the bump @hoangzinh , paying now.

[jliexpensify]

Paid, and job closed in Upworks!