[HOLD for payment 2023-04-07] [$1000] DEV: Preview of the image is showing broken and does not display image

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to chat and upload any image.
2. Press on that image to see preview.

Expected Result:

Preview should be full screen and should show image.

Actual Result:

Web: Preview screen is divided into 2 parts and does not display content and images
Mobile Native: Error (see attachment)

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?: Occurs in Main branch
Reproducible in production?: Occurs in Main branch
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @ArekChr
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679991710703309

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01936dec4fc845c81d
• Upwork Job ID: 1640771855856402432
• Last Price Increase: 2023-03-28

[MelvinBot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[trjExpensify]

I can't test this on dev, but seems like we believe it's a regression from this PR. CC: @stitesExpensify @luacmartins @perunt

Adding external but if #14652 goes to staging this becomes a deploy blocker I think.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01936dec4fc845c81d

[MelvinBot]

Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[MelvinBot]

Triggered auto assignment to @cristipaval (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[situchan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

attachment modal views are broken

What is the root cause of that problem?

#14652 caused this regression.

App/src/components/Modal/BaseModal.js

Lines 175 to 181 in 752ac61

	<KeyboardAvoidingView
	behavior="padding"
	style={styles.w100}
	shouldApplyToAndroid
	>
	{content}
	</KeyboardAvoidingView>

KeyboardAvoidingView height is not stretched. Neither flex: 1 nor height: '100%' is added in style.
But we can't simply add these styles because emoji picker doesn't need to be stretched.

What changes do you think we should make in order to solve the problem?

• completely remove android specific KeyboardAvoidingView introduced in this PR
• revert changes in BaseModal (return normal view as before)
• pass avoidKeyboard={true} to PopoveWithMeasuredContent in EmojiPicker component
  this is to push emoji picker above keyboard on iOS
• pass statusBarTranslucent={false} to PopoveWithMeasuredContent in EmojiPicker component
  this is to push emoji picker above keyboard on Android

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Current assignee @cristipaval is eligible for the Engineering assigner, not assigning anyone new.

[MelvinBot]

📣 @SeniorEng! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[kadiealexander]

@situchan recognised that #16641 is a duplicate issue with the same root cause as this issue. @cristipaval @sobitneupane can I assign you both to this one as well to ensure it's covered?

[luacmartins]

We reverted the offending PR. This should be fixed once the staging CP is finished.

[trjExpensify]

Awesome, thanks.

[luacmartins]

We shipped the fix and this is solved. Closing.

[luacmartins]

Reopening to process payments

[trjExpensify]

@ArekChr can you apply here on Upwork please, so I can pay you for the bug report? Thanks! https://www.upwork.com/jobs/~01936dec4fc845c81d

[cristipaval]

Hey @trjExpensify! @ArekChr is from Callstack.

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.92-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert "Emoji search on mobile" #16659

If no regressions arise, payment will be issued on 2023-04-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane / @cristipaval / @luacmartins / @stitesExpensify] The PR that introduced the bug has been identified. Link to the PR: Emoji search on mobile #14652
• [@sobitneupane / @cristipaval / @luacmartins / @stitesExpensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Emoji search on mobile #14652 (comment)
• [@sobitneupane / @cristipaval / @luacmartins / @stitesExpensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@trjExpensify] Determine if we should create a regression test for this bug.
• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[trjExpensify]

Ah, right. Duh!

Reopening to process payments

@luacmartins we're all good here, yeah?

[luacmartins]

If we paid everyone out, then we are good!

[trjExpensify]

Ha, well there's no-one to pay out I don't think? 😅

[luacmartins]

Ah just saw the previous comments. All good then! Closing.