[HOLD for payment 2023-04-10] [HOLD for payment 2023-04-07] Payment - Crash when clicking on Bank Account in the Payment tab

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the App
2. Login with any account
3. Go to Settings -> Payment -> Abb payment method -> Bank account

Expected Result:

NO crash when clicking on Bank Account in the Payment tab

Actual Result:

Crash when clicking on Bank Account in the Payment tab

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.92.1

Reproducible in staging?: Yes

Reproducible in production?: NO

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5999287_video_2023-03-30_20-34-21.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[situchan]

I think #16323 caused this regression

[fedirjh]

I agree with @situchan , this is a regression from #16323 , This line

App/src/components/PlaidLink/index.native.js

Lines 8 to 10 in 2398744

	// We are stashing initial props in a ref since we don't want a new token to trigger the link to open again
	// and just want openLink() to be called once
	const propsRef = useRef(props.token);

propsRef should hold all the props , this change should fix this issue

 const propsRef = useRef(props);

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.92-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix propsRef initialization in native PlaidLink component #16778

If no regressions arise, payment will be issued on 2023-04-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[luacmartins]

Removing the deploy blocker label since this has been fixed

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.93-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix propsRef initialization in native PlaidLink component #16778

If no regressions arise, payment will be issued on 2023-04-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

@francoisl Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MelvinBot]

@francoisl Whoops! This issue is 2 days overdue. Let's get this updated quick!

[francoisl]

This was a fix for a deploy blocker. The PR that caused the issue has already been commented on, all done here.