Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace Chat - Workspace chat has Request money option with no attendees and Request button disabled #16837

Closed
6 tasks done
kbecciv opened this issue Mar 31, 2023 · 6 comments

Comments

@kbecciv
Copy link

kbecciv commented Mar 31, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Login to https://staging.new.expensify.com/
  2. Create workspace
  3. Go to Workspace chat
  4. Click + an proceed with money Request

Expected Result:

I would expect that there should be no request money option available.

Actual Result:

Workspace chat has Request money option with no attendees and Request button disabled

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.94.3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6001278_video_78.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Mar 31, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Everybody was OOO, so I assigned 10 random eligible people.

@kbecciv
Copy link
Author

kbecciv commented Mar 31, 2023

Putting Deploy blocker label, because production doesn't have Request Money option on Workspace chat.

7

@techievivek
Copy link
Contributor

Not a blocker, we just added the request money option in the workspace chat: #16670
@luacmartins do we need to update the tests in the testRail so Applause does not flag this as a bug?

@techievivek techievivek removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Mar 31, 2023
@mountiny
Copy link
Contributor

mountiny commented Apr 1, 2023

@kbecciv this is being actively worked on as Part of the manual requests

This is behind beta so its ok the flow is not complete yet, i think we should wait for testrail changes until we finish most of the Mannual request project which will allow employees to submit expenses in the workspace chat.

I would close this issue in the meantime, there is no bug here

@mountiny mountiny closed this as not planned Won't fix, can't repro, duplicate, stale Apr 1, 2023
@kbecciv
Copy link
Author

kbecciv commented Apr 1, 2023

@mountiny Great, thank your for explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment