-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-04-13] [HOLD for payment 2023-04-12] Chat - Infinity loading displayed for link Valid ID https://staging.new.expensify.com/r/1234 instead "You don't have access to this chat message" in the conversation history. #16897
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @marcaaron ( |
Issue is not reproduced in Production, attaching video. RPReplay_Final1680571453.MP4 |
This issue came from staging backend. To reproduce in dev locally, enable |
👀 into it now |
Seems related to https://github.com/Expensify/Web-Expensify/pull/36929 |
Opening a fix PR. I think the solution is to handle the |
Job added to Upwork: https://www.upwork.com/jobs/~01d498a31ce02d2fa7 |
Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt ( |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.94-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-04-12. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.95-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-04-13. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
This looks resolved, anything else needed to be done here? @marcaaron |
Payment for @mollfpr |
Thanks for the fix, going to remove the Deploy Blocker label so that it doesn't block the deploy moving forward. |
I think this is ready for payment but no BZ is assigned gonna add the bug label to get some help (I think it should work..?) |
Triggered auto assignment to @kadiealexander ( |
Bug0 Triage Checklist (Main S/O)
|
@mollfpr just sent you a contract in Upwork :) |
@kadiealexander Accepted, thank you! |
Thanks for the speed @mollfpr! All paid. Leaving this open in case there are any other actions @marcaaron. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Verify You see a You don't have access to this chat message in the conversation history
Actual Result:
Infinity loading displayed for link Valid ID https://staging.new.expensify.com/r/1234 instead "You don't have access to this chat message" in the conversation history.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.2.94.0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/3322825
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6004979_infinity.1.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: