Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-04-13] [HOLD for payment 2023-04-12] Chat - Infinity loading displayed for link Valid ID https://staging.new.expensify.com/r/1234 instead "You don't have access to this chat message" in the conversation history. #16897

Closed
6 tasks done
kbecciv opened this issue Apr 4, 2023 · 22 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@kbecciv
Copy link

kbecciv commented Apr 4, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Log in to NewDot
  2. On the URL change the conversation ID to any combination of 1-4 numbers. E.g https://staging.new.expensify.com/r/1234

Expected Result:

Verify You see a You don't have access to this chat message in the conversation history

Actual Result:

Infinity loading displayed for link Valid ID https://staging.new.expensify.com/r/1234 instead "You don't have access to this chat message" in the conversation history.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.94.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/3322825

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6004979_infinity.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d498a31ce02d2fa7
  • Upwork Job ID: 1643282360869244928
  • Last Price Increase: 2023-04-04
@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Apr 4, 2023
@OSBotify
Copy link
Contributor

OSBotify commented Apr 4, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kbecciv
Copy link
Author

kbecciv commented Apr 4, 2023

Issue is not reproduced in Production, attaching video.

RPReplay_Final1680571453.MP4

@situchan
Copy link
Contributor

situchan commented Apr 4, 2023

This issue came from staging backend.
api?command=OpenReport returns jsonCode: 403 which expects 200.
This doesn't happen on production backend.

To reproduce in dev locally, enable Use Staging Server.

@marcaaron
Copy link
Contributor

👀 into it now

@marcaaron
Copy link
Contributor

@marcaaron
Copy link
Contributor

Opening a fix PR. I think the solution is to handle the failureData case when calling OpenReport.

@marcaaron marcaaron added the Internal Requires API changes or must be handled by Expensify staff label Apr 4, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~01d498a31ce02d2fa7

@MelvinBot
Copy link

Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (Internal)

@MelvinBot
Copy link

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Apr 5, 2023
@melvin-bot melvin-bot bot changed the title Chat - Infinity loading displayed for link Valid ID https://staging.new.expensify.com/r/1234 instead "You don't have access to this chat message" in the conversation history. [HOLD for payment 2023-04-12] Chat - Infinity loading displayed for link Valid ID https://staging.new.expensify.com/r/1234 instead "You don't have access to this chat message" in the conversation history. Apr 5, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 5, 2023
@MelvinBot
Copy link

Reviewing label has been removed, please complete the "BugZero Checklist".

@MelvinBot
Copy link

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.94-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-04-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@marcaaron marcaaron assigned mollfpr and unassigned s77rt Apr 5, 2023
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Apr 6, 2023
@melvin-bot melvin-bot bot added the Weekly KSv2 label Apr 6, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-04-12] Chat - Infinity loading displayed for link Valid ID https://staging.new.expensify.com/r/1234 instead "You don't have access to this chat message" in the conversation history. [HOLD for payment 2023-04-13] [HOLD for payment 2023-04-12] Chat - Infinity loading displayed for link Valid ID https://staging.new.expensify.com/r/1234 instead "You don't have access to this chat message" in the conversation history. Apr 6, 2023
@MelvinBot
Copy link

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.95-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-04-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@thienlnam
Copy link
Contributor

This looks resolved, anything else needed to be done here? @marcaaron

@marcaaron
Copy link
Contributor

Payment for @mollfpr

@francoisl
Copy link
Contributor

Thanks for the fix, going to remove the Deploy Blocker label so that it doesn't block the deploy moving forward.

@francoisl francoisl removed the DeployBlockerCash This issue or pull request should block deployment label Apr 10, 2023
@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Apr 11, 2023
@marcaaron
Copy link
Contributor

I think this is ready for payment but no BZ is assigned gonna add the bug label to get some help (I think it should work..?)

@melvin-bot melvin-bot bot removed the Overdue label Apr 13, 2023
@marcaaron marcaaron added the Bug Something is broken. Auto assigns a BugZero manager. label Apr 13, 2023
@MelvinBot
Copy link

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

MelvinBot commented Apr 13, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@kadiealexander
Copy link
Contributor

@mollfpr just sent you a contract in Upwork :)

@mollfpr
Copy link
Contributor

mollfpr commented Apr 14, 2023

@kadiealexander Accepted, thank you!

@kadiealexander
Copy link
Contributor

Thanks for the speed @mollfpr! All paid. Leaving this open in case there are any other actions @marcaaron.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

10 participants