[HOLD for payment 4/18] Payment issue for E/App PR#15858

[melvin-bot]

Issue created to compensate the Contributor+ member for their work on #15858
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/259220.
Contributor+ member who reviewed the PR - @parasharrajat.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c0b560a7c62d8282
• Upwork Job ID: 1645454169639534592
• Last Price Increase: 2023-04-10

[MelvinBot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01c0b560a7c62d8282

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

Current assignee @parasharrajat is eligible for the Internal assigner, not assigning anyone new.

[MelvinBot]

@mallenexpensify, @parasharrajat Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mallenexpensify]

@parasharrajat , I'm assuming compensation will be reduced by 50% because of this comment about a regression. If not, please provide details.
#15858 (comment)

[parasharrajat]

As per the rules, yes it should be. But It happened in the additional refactor not part of the issue we were trying to solve and no new issue was created for this #15758. It was tackled as part of the old issue #15758. Now, please proceed as you prefer.

[mallenexpensify]

@parasharrajat , do you want to address in #contributor-plus as a possible update to our process? I'm not familiar with all the details but, if additional work is being done on a PR, outside of specifically fixing the issue from the OP, and a regression happens as part of the additional work, I'm unsure if C+ should be penalized. Reasoning, we don't want all C+ only doing the bare-minimum to fix a bug, this setup would encourage them to never want to do anything additional that would improve the app, for risk of being docked pay

[parasharrajat]

this setup would encourage them to never want to do anything additional that would improve the app, for risk of being docked pay

Sorry, I do not understand. Do you not want C+ to add additional things that improve the app

[mallenexpensify]

@parasharrajat, if we penalize contributors for going above and beyond the main fix, then that provides a reason for them not to not do additional work. I'm assuming we don't want this setup because we'd always have to create new bugs/issues, even for tiny improvements (which can be worked on in tandem with fixing the main bug).

[MelvinBot]

@mallenexpensify, @parasharrajat Whoops! This issue is 2 days overdue. Let's get this updated quick!

[parasharrajat]

I didn't get the time to initiate a discussion. I won't be able to do it any soon as I am quite busy with work ATM.

[mallenexpensify]

No worries Rajat, I'm checking internally on this specific issue then plan to start a discussion in #contributor-plus about a quick update
https://github.com/Expensify/Expensify/issues/259220#issuecomment-1518362260

[mallenexpensify]

From @arosiclair below, so the 50% reduction in compensation is in effect. @parasharrajat can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01c0b560a7c62d8282

But It happened in the additional refactor not part of the issue we were trying to solve

That part isn't true. That specific regression was introduced in #15858. There were other regressions from the other related PR so maybe he confused the two.

[parasharrajat]

@mallenexpensify Done.

[mallenexpensify]

Paid, closing!