Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOU - Invalid characters error message for "<>" brackets in IOU description #17577

Closed
4 of 6 tasks
kbecciv opened this issue Apr 18, 2023 · 7 comments
Closed
4 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kbecciv
Copy link

kbecciv commented Apr 18, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #16957

Action Performed:

  1. Go https://staging.new.expensify.com/ and login
  2. Click "+", Request money
  3. Input amount, click Next button, select account
  4. Click Description
  5. Input "Tokyo <> Mexico" and submit

Expected Result:

Description should be accepted

Actual Result:

Error message is displayed saying "Invalid character"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • Windows / Chrome
  • MacOS / Desktop

Version Number: 1.3.1.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6022397_video_53.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 18, 2023
@MelvinBot
Copy link

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@jayeshmangwani
Copy link
Contributor

This is intentional, we are showing an error if the value contains the HTML tag in the Form component input

App/src/components/Form.js

Lines 197 to 198 in f54a8bd

// Add a validation error here because it is a string value that contains HTML characters
validationErrors[inputID] = this.props.translate('common.error.invalidCharacter');

@mountiny
Copy link
Contributor

cc @tienifr and @pecanoro since you were involved in the linked PR, I dont think this is a deploy blocker, and not sure if its an issue at all, can you confirm and decide if we want to fix this or close it please given the comment from @jayeshmangwani above? Thanks!

@alexpensify
Copy link
Contributor

Thanks, @mountiny and @jayeshmangwani for this update!

@pecanoro
Copy link
Contributor

Oh this is pretty interesting, it seems we fixed the bug while we were actually implementing code to avoid sending those characters at the same time. I guess we can close it again since it seems it's a new restriction recently implemented.

@mountiny
Copy link
Contributor

I agree, closing thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

6 participants