-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$2000] IOS -Workspace - Workspaces name displayed twice when using the plus button from the workspace chat #17653
Comments
Triggered auto assignment to @arielgreen ( |
Bug0 Triage Checklist (Main S/O)
|
@kbecciv is this only repro on ios or everywhere cc @cristipaval since this is linked to your PR |
@mountiny Only IOS app, checked all environments this morning. |
Wow, interesting, wouldnt expect that. I think we can wait for @cristipaval to have a look, it could be exported but lets keep in mind developers will need beta |
Assigned me to this one to have a look. |
@cristipaval, @arielgreen Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
I will look into this asap. |
Setting internal for now |
Job added to Upwork: https://www.upwork.com/jobs/~01e1186a29d23762df |
Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane ( |
@kbecciv I can't reproduce this one. I tried on the simulator as well as on my physical iOS device. Is this always reproducible with the latest build? |
@kbecciv is this one still reproducible? |
Hello @cristipaval! Checking with team, will update you shortly. |
@cristipaval Issue is reproductible on build 1.3.8.8 when using expensifail account, video attached. RPReplay_Final1683028565.MP4 |
@cristipaval @rushatgabhane @arielgreen this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
Thanks @kbecciv ! I'll try reproducing again. |
Yes I could reproduce this. Thanks @kbecciv for bearing with me. Taking a look soon. |
This can't be related to the api, I'm almost sure it's a bug in the front end and I can't spend time fixing it as I am focused on some other important issue on Manual Requests. Making this one external. |
Current assignee @arielgreen is eligible for the External assigner, not assigning anyone new. |
Current assignee @rushatgabhane is eligible for the External assigner, not assigning anyone new. |
Current assignee @cristipaval is eligible for the External assigner, not assigning anyone new. |
@cristipaval @rushatgabhane @arielgreen this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks! |
Going to bump the price up on this one since we lost a few weeks. |
Upwork job price has been updated to $2000 |
Tagging @s77rt, maybe he is interested in this one as he already spent some time on this piece of code recently. |
Is this still reproducible? Wasn't it fixed by #18717? |
Yeah seems like a dupe of #18708. Probably fixed by now. Let me know if this is still reproducible. |
Hmm, yeah good point, I'll test it soon. |
Tested with latest staging v1.3.14-0 and the issue is solved. Thanks a lot @s77rt ! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found when executing PR #17132
Action Performed:
Expected Result:
Only one Workspaces name displayed when using the plus button from the workspace chat
Actual Result:
Workspaces name displayed twice when using the plus button from the workspace chat
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.1.3
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
RPReplay_Final1681910090.1.MP4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: