Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$2000] IOS -Workspace - Workspaces name displayed twice when using the plus button from the workspace chat #17653

Closed
1 of 6 tasks
kbecciv opened this issue Apr 19, 2023 · 30 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kbecciv
Copy link

kbecciv commented Apr 19, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #17132

Action Performed:

  1. Login with an admin account and create a new workspace
  2. Invite an employee to the workspace
  3. Login with the employee account
  4. Select Workspace Chat
  5. Initiate a money request to the workspace using the plus button from the workspace chat

Expected Result:

Only one Workspaces name displayed when using the plus button from the workspace chat

Actual Result:

Workspaces name displayed twice when using the plus button from the workspace chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.1.3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1681910090.1.MP4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e1186a29d23762df
  • Upwork Job ID: 1650659194258268160
  • Last Price Increase: 2023-05-10
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 19, 2023
@MelvinBot
Copy link

Triggered auto assignment to @arielgreen (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@mountiny
Copy link
Contributor

@kbecciv is this only repro on ios or everywhere

cc @cristipaval since this is linked to your PR

@kbecciv
Copy link
Author

kbecciv commented Apr 19, 2023

@mountiny Only IOS app, checked all environments this morning.

@mountiny
Copy link
Contributor

Wow, interesting, wouldnt expect that. I think we can wait for @cristipaval to have a look, it could be exported but lets keep in mind developers will need beta

@cristipaval cristipaval self-assigned this Apr 20, 2023
@cristipaval
Copy link
Contributor

Assigned me to this one to have a look.

@melvin-bot melvin-bot bot added the Overdue label Apr 24, 2023
@MelvinBot
Copy link

@cristipaval, @arielgreen Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@cristipaval
Copy link
Contributor

I will look into this asap.

@melvin-bot melvin-bot bot removed the Overdue label Apr 24, 2023
@arielgreen
Copy link
Contributor

Setting internal for now

@arielgreen arielgreen added the Internal Requires API changes or must be handled by Expensify staff label Apr 25, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~01e1186a29d23762df

@MelvinBot
Copy link

Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (Internal)

@cristipaval
Copy link
Contributor

@kbecciv I can't reproduce this one. I tried on the simulator as well as on my physical iOS device. Is this always reproducible with the latest build?

@melvin-bot melvin-bot bot added the Overdue label May 1, 2023
@cristipaval
Copy link
Contributor

@kbecciv is this one still reproducible?

@melvin-bot melvin-bot bot removed the Overdue label May 1, 2023
@kbecciv
Copy link
Author

kbecciv commented May 2, 2023

Hello @cristipaval! Checking with team, will update you shortly.

@kbecciv
Copy link
Author

kbecciv commented May 2, 2023

@cristipaval Issue is reproductible on build 1.3.8.8 when using expensifail account, video attached.

RPReplay_Final1683028565.MP4

@MelvinBot
Copy link

@cristipaval @rushatgabhane @arielgreen this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label May 3, 2023
@cristipaval
Copy link
Contributor

Thanks @kbecciv ! I'll try reproducing again.

@melvin-bot melvin-bot bot removed the Overdue label May 4, 2023
@melvin-bot melvin-bot bot added the Overdue label May 8, 2023
@cristipaval
Copy link
Contributor

cristipaval commented May 8, 2023

Yes I could reproduce this. Thanks @kbecciv for bearing with me. Taking a look soon.

@melvin-bot melvin-bot bot removed the Overdue label May 8, 2023
@cristipaval
Copy link
Contributor

This can't be related to the api, I'm almost sure it's a bug in the front end and I can't spend time fixing it as I am focused on some other important issue on Manual Requests. Making this one external.

@cristipaval cristipaval added External Added to denote the issue can be worked on by a contributor and removed Internal Requires API changes or must be handled by Expensify staff labels May 9, 2023
@melvin-bot melvin-bot bot changed the title IOS -Workspace - Workspaces name displayed twice when using the plus button from the workspace chat [$1000] IOS -Workspace - Workspaces name displayed twice when using the plus button from the workspace chat May 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 9, 2023

Current assignee @arielgreen is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented May 9, 2023

Current assignee @rushatgabhane is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 9, 2023

Current assignee @cristipaval is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented May 10, 2023

@cristipaval @rushatgabhane @arielgreen this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@arielgreen
Copy link
Contributor

Going to bump the price up on this one since we lost a few weeks.

@arielgreen arielgreen changed the title [$1000] IOS -Workspace - Workspaces name displayed twice when using the plus button from the workspace chat [$2000] IOS -Workspace - Workspaces name displayed twice when using the plus button from the workspace chat May 10, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 10, 2023

Upwork job price has been updated to $2000

@cristipaval
Copy link
Contributor

Tagging @s77rt, maybe he is interested in this one as he already spent some time on this piece of code recently.

@s77rt
Copy link
Contributor

s77rt commented May 11, 2023

Is this still reproducible? Wasn't it fixed by #18717?

@s77rt
Copy link
Contributor

s77rt commented May 11, 2023

Yeah seems like a dupe of #18708. Probably fixed by now. Let me know if this is still reproducible.

@cristipaval
Copy link
Contributor

Hmm, yeah good point, I'll test it soon.

@melvin-bot melvin-bot bot added the Overdue label May 15, 2023
@cristipaval
Copy link
Contributor

Tested with latest staging v1.3.14-0 and the issue is solved. Thanks a lot @s77rt !

@melvin-bot melvin-bot bot removed the Overdue label May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

7 participants