[HOLD for payment 2023-06-13] Weird behavior while dragging zoomed image in preview

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any chat and upload 2 large images
2. Tap one image to show preview
3. Double tap image to zoom in
4. Slide left (or right) to view next image

Expected result:

Previewing other attachments should not be possible in zoomed state

Actual result:

Image moves along with sliding to next attachment

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

bug.mp4

KBTX7069.1.MP4

Expensify/Expensify Issue URL:
Issue reported by: @0xmiroslav
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681890084225809

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010fcefc4fc29f76b6
• Upwork Job ID: 1649428294754996224
• Last Price Increase: 2023-04-21

[MelvinBot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~010fcefc4fc29f76b6

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

[terrysahaidak]

Assign this one to me.

[MelvinBot]

@puneetlath, @terrysahaidak, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[puneetlath]

@terrysahaidak is actively working on it. We chatted in Slack a bit about it today.

[0xmiros]

#17647 was just merged today.
Please work based on latest codebase.
I think the solution would be to prevent swiping to prev/next attachments while image is zoomed.
This is already done in PDF zoom case.

[terrysahaidak]

#17647 was just merged today.
Please work based on latest codebase.
I think the solution would be to prevent swiping to prev/next attachments while image is zoomed.
This is already done in PDF zoom case.

we can actually preserve the swiping even if the image is zoomed thanks to Gesture Handler v2 and Reanimated.

VID_20230424_233207_091.mp4

[0xmiros]

Does that work on android as well? I experienced different weird behavior when I report this bug.

[terrysahaidak]

@0xmiroslav yeah i got it working on android, but I can't get the continuous swipe gesture to be working, like on iOS. It stops near the edge. Well, Android as always.

[puneetlath]

@terrysahaidak how is this one going?

[terrysahaidak]

@puneetlath, I've been stuck with some other tickets the last few days + public holiday here, but have some progress and will post it here tomorrow, thanks for reminding :)

[MelvinBot]

@puneetlath @terrysahaidak @aimane-chnaif this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[terrysahaidak]

Yes, been working on it today and continue tomorrow to get the best solution.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.24-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Disable attachment carousel scroll when zoomed in #18634

If no regressions arise, payment will be issued on 2023-06-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter @0xmiroslav
• Contributor that fixed the issue n/a
• Contributor+ that helped on the issue and/or PR @aimane-chnaif

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[puneetlath]

@terrysahaidak how do you want to handle further improvements. Will you open a separate issue?

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[puneetlath]

@0xmiroslav sent you a contract for reporting here: https://www.upwork.com/nx/wm/workroom/33854304/overview

@aimane-chnaif sent you a contract for C+ here: https://www.upwork.com/nx/wm/offer/24940750

@anmurali assigning you for payment since I'll be OOO next week. Thanks!

[anmurali]

@aimane-chnaif - can you finish the BZ checklist and let me know if we need to add regression steps?

[aimane-chnaif]

Regarding BugZero Checklist:

No PRs caused regression. I think the bug always existed after we implement carousel in #7862.

Regression Test Proposal:

1. Go to any chat and send multiple images
2. Open one image
3. Zoom in by double tap
4. Swipe left/right
5. Verify that it doesn't switch to another attachment until you zoom out by double tap/pinch out

I think this can be combined with #15988 (comment)

[anmurali]

I paid @aimane-chnaif and @0xmiroslav
https://github.com/Expensify/Expensify/issues/293225

[puneetlath]

Thanks everyone!

Going to go ahead and close this out since the regression test was added in the issue @aimane-chnaif linked.