Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-05-22] Add custom renderer for here mentions #17886

Closed
puneetlath opened this issue Apr 24, 2023 · 17 comments
Closed

[HOLD for payment 2023-05-22] Add custom renderer for here mentions #17886

puneetlath opened this issue Apr 24, 2023 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.

Comments

@puneetlath
Copy link
Contributor

puneetlath commented Apr 24, 2023

As part of the mentions project, we will be adding a custom renderer called MentionHereRenderer for the tag. The custom renderer will be similar to the AnchorRenderer.

The details of the implementation are described in the doc here.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0155f6363e8ab0243e
  • Upwork Job ID: 1654553630802956288
  • Last Price Increase: 2023-05-05
@puneetlath puneetlath added Daily KSv2 NewFeature Something to build that is a new item. labels Apr 24, 2023
@puneetlath puneetlath self-assigned this Apr 24, 2023
@MelvinBot
Copy link

Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

@puneetlath
Copy link
Contributor Author

@robertKozik will you want to take this one as well? It's basically the same as #17885.

@robertKozik
Copy link
Contributor

Sure. I'll do it

@robertKozik
Copy link
Contributor

@puneetlath I've checked the design doc, but want to make sure - in @here mention there is no onPress action nor tooltip?

@puneetlath
Copy link
Contributor Author

That's correct!

@puneetlath
Copy link
Contributor Author

@robertKozik I'd imagine this will be nearly identical to user mentions, so I'm hoping we can get a PR up and merged quite quickly. Maybe by Monday?

@robertKozik
Copy link
Contributor

Yeah, very similar but simpler.

@puneetlath
Copy link
Contributor Author

@parasharrajat adding you as the C+ for this one too since you have all the context, so should be an easy review.

@puneetlath puneetlath added the Internal Requires API changes or must be handled by Expensify staff label May 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 5, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0155f6363e8ab0243e

@melvin-bot
Copy link

melvin-bot bot commented May 5, 2023

Current assignee @parasharrajat is eligible for the Internal assigner, not assigning anyone new.

@parasharrajat
Copy link
Member

Got it. Thanks.

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label May 8, 2023
@robertKozik
Copy link
Contributor

Created draft PR after the user mentions pr will be merged I'll resolve conflicts and It will be ready too

@puneetlath
Copy link
Contributor Author

Merged!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 15, 2023
@melvin-bot melvin-bot bot changed the title Add custom renderer for here mentions [HOLD for payment 2023-05-22] Add custom renderer for here mentions May 15, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 15, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 15, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented May 15, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-05-22. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@puneetlath
Copy link
Contributor Author

Sent @parasharrajat a contract offer in Upwork.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 21, 2023
@puneetlath
Copy link
Contributor Author

All paid. Thanks again everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests

4 participants