-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-05-22] Add custom renderer for here mentions #17886
Comments
Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new. |
@robertKozik will you want to take this one as well? It's basically the same as #17885. |
Sure. I'll do it |
@puneetlath I've checked the design doc, but want to make sure - in |
That's correct! |
@robertKozik I'd imagine this will be nearly identical to user mentions, so I'm hoping we can get a PR up and merged quite quickly. Maybe by Monday? |
Yeah, very similar but simpler. |
@parasharrajat adding you as the C+ for this one too since you have all the context, so should be an easy review. |
Job added to Upwork: https://www.upwork.com/jobs/~0155f6363e8ab0243e |
Current assignee @parasharrajat is eligible for the Internal assigner, not assigning anyone new. |
Got it. Thanks. |
Created draft PR after the user mentions pr will be merged I'll resolve conflicts and It will be ready too |
Merged! |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-05-22. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
Sent @parasharrajat a contract offer in Upwork. |
All paid. Thanks again everyone! |
As part of the mentions project, we will be adding a custom renderer called MentionHereRenderer for the tag. The custom renderer will be similar to the AnchorRenderer.
The details of the implementation are described in the doc here.
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: