Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New marker line overlaps on the context menu items when marking a message as "unread" #18358

Closed
2 of 6 tasks
kavimuru opened this issue May 3, 2023 · 13 comments · Fixed by #18360
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering Reviewing Has a PR in review

Comments

@kavimuru
Copy link

kavimuru commented May 3, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app
  2. Open any report
  3. Send any message
  4. Mark it as unread
  5. Observe that new marker is over hover menu and hover menu items are not selectable

Expected Result:

New marker should not overlap hover menu items and should not block menu items from click

Actual Result:

App overlaps new marker on hover menu items and makes the hover menu items non clickable

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.9.14
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.467.mp4
overlapping.new.and.not.clickable.hover.items.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683084751140789

View all open jobs on GitHub

@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 3, 2023
@MelvinBot
Copy link

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

OSBotify commented May 3, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@sonialiap
Copy link
Contributor

I'm out for the night, if you need a BZ to do anything ASAP then please reassign

@isagoico
Copy link

isagoico commented May 3, 2023

Added MacOS / Desktop to the reproducible platforms.


Going to take the opportunity to update this regression TC, this issue made us realize this possible scenario was not covered in the existing run:

We're not verifying that the New messages line should display when using the mark as unread button. Will update this message when updated. Resolved - TC has been updated and will be tested on every deploy with the regression run. 2 New steps were added:
image

@marcaaron
Copy link
Contributor

Seems most likely caused by this #17704

@marcaaron
Copy link
Contributor

Gonna revert it.

@dhanashree-sawant
Copy link

Hi @sonialiap, @marcaaron, @dangrous sorry its my first deploy blocker issue so not aware whether eligible for reporting bonus or not but if this report had triggered the changes to fix the issue, will I be eligible for reporting bonus?

@dangrous
Copy link
Contributor

Oh good question @dhanashree-sawant - let me reopen this so we can discuss (I'm not 100% on the process either)

@dangrous dangrous reopened this May 10, 2023
@sonialiap sonialiap added Daily KSv2 and removed Hourly KSv2 labels May 10, 2023
@sonialiap
Copy link
Contributor

Checking with the team

@sonialiap
Copy link
Contributor

The team agrees that reporting an issue that led to a fix (including a revert) should be compensated

@dhanashree-sawant I've sent an offer to you 😄

Upwork post https://www.upwork.com/jobs/~015b100cf73ac86202

@sonialiap
Copy link
Contributor

Paid ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering Reviewing Has a PR in review
Projects
None yet
9 participants