[HOLD for payment 2023-05-25] [$1000] mWeb- Magic Code -Unable to paste the Magic code on mWeb iOS/Safari

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to URL staging
2. Enter any email address
3. Navigate to email and copy Magic Code
4. Return to sign in page and past Magic Code

Expected Result:

Able to past the Magic code on mWeb iOS/Safari

Actual Result:

Unable to past the Magic code on mWeb iOS/Safari

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.10.2

Reproducible in staging?: Yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6043809_login.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a6d09225e8957fc8
• Upwork Job ID: 1655600135973437440
• Last Price Increase: 2023-05-08

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[bfitzexpensify]

Reproduced.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a6d09225e8957fc8

[melvin-bot]

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

Triggered auto assignment to @pecanoro (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[akinwale]

Proposal

Please re-state the problem that we are trying to solve in this issue.

A copied magic code cannot be pasted into the input spaces provided on iOS Safari.

What is the root cause of that problem?

In iOS Safari, an input in a container with its opacity set to 0 (completely transparent) cannot handle user interaction, hence the Paste option is never shown after long pressing in the input area.

What changes do you think we should make in order to solve the problem?

Modify the MagicCodeInput component with the following steps:

1. Change styles.opacity0 to styles.bgTransparent for the View containing the TextInput.

https://github.com/Expensify/App/blob/main/src/components/MagicCodeInput.js#L305

2. Add an inputStyle prop to the TextInput with a new style: styles.magicCodeInputTransparent. styles.magicCodeInputTransparent can be defined like so:

magicCodeInputTransparent: {
    caretColor: 'transparent',
    color: 'transparent',
},

3. Add the caretHidden prop to the TextInput to hide the caret on iOS and Android native.

What alternative solutions did you explore? (Optional)

None.

Screen.Recording.2023-05-08.at.18.10.35.mov

[mananjadhav]

I think @akinwale's proposal will work. We'll just need to verify if it breaks anything for Android Chrome, Native Apps.

@pecanoro the above proposal looks good.

[akinwale]

I think @akinwale's proposal will work. We'll just need to verify if it breaks anything for Android Chrome, Native Apps.

@pecanoro the above proposal looks good.

@mananjadhav I have tested on the following platforms and it works fine:

• iOS Safari
• iOS Native
• Desktop
• Web

I am about to verify on Android Chrome and native. Will post an update shortly.

[mananjadhav]

Thanks for being proactive @akinwale. I think we can work that out during the PR.

@kbecciv can we please correct the typos in the GH title?

[$1000] mWeb - Magic Code - Unable to paste the Magic code on mWeb iOS/Safari

[kbecciv]

@mananjadhav Corrected, thank you

[akinwale]

@kbecciv The first bit still shows up as "Megic" instead of "Magic". Would the Upwork job title also be updated?

[kbecciv]

@akinwale Yes, updated

[pecanoro]

Interesting root cause 😄 EIther way, the proposal sounds good to me too, so assigning @akinwale

[melvin-bot]

📣 @akinwale You have been assigned to this job by @pecanoro!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[akinwale]

@mananjadhav @pecanoro I have applied to the Upwork job and the PR is ready for review. Thanks.

[pecanoro]

@akinwale Awesome, I will review it today!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.15-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: allow pasting magic codes in iOS Safari #18771

If no regressions arise, payment will be issued on 2023-05-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mananjadhav]

#16076 This the PR where we added the MagicCodeInput. I've added a comment on the PR with the reasoning.

I think we should add a regression test. It is fairly easy to miss this when we update any styling and difficult to cover in the QA unless we have a test for the same.

Regression Test

1. Navigate to the URL for the Expensify App in iOS Safari.
2. Attempt to login with an email address.
3. Copy the magic code from the email received.
4. Attempt to paste the magic code in the input field for the Expensify sign-in flow.
5. Verify that the magic code was actually pasted.

I copied the test from the PR. What do you folks think? @pecanoro @akinwale @bfitzexpensify ?

[bfitzexpensify]

Proposed regression steps in https://github.com/Expensify/Expensify/issues/286310.

All payments complete. Thanks for the work here! Closing this out.

[mananjadhav]

@bfitzexpensify Is it not eligible for the timeline bonus, we had 2 days weekend in between?

[bfitzexpensify]

@mananjadhav you're correct, I misread my calendar! Sent out an offer to you both for the bonus payment.

[mananjadhav]

Thank you @bfitzexpensify. Accepted the second offer.

[bfitzexpensify]

Thanks for calling it out! Both bonuses have now been paid out.