[HOLD for payment 2023-06-07] [$1000] Bank Account - User goes to 'Connect manually' flow after 'Start Over' offline

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open App, create/open workspace and start to add bank account in workspace
2. Exits in the middle of the flow (after page 'Company Information' or 'Personal Information')
3. Return to the flow again > Settings > Workspaces > Connect bank account
4. Go offline
5. Select Start Over on the page 'Almost done!'
6. User get page page 'You appear to be offline'
7. Go Online

Expected Result:

The flow of adding bank Account is reset. User is on the start 'Connect bank account' page.

Actual Result:

The flow of adding Bank Account is reset. User goes to goes to 'Connect manually' flow.

Workaround:

Uknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.10.2

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6044134_BA-manual-after-start-over-offline.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01aeed1cce3edf8b8d
• Upwork Job ID: 1659275638396211200
• Last Price Increase: 2023-05-18

[melvin-bot]

Triggered auto assignment to @arielgreen (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[greg-schroeder]

I'm dealing with a few things and I need to re-assign this. The auto-assigner hath chosen you @arielgreen - I'm sorry about the delay on this, but I appreciate you stepping in if you're able. <3

[melvin-bot]

@arielgreen Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[arielgreen]

Happy to take this on @greg-schroeder ! Working on it tomorrow morning

[HezekielT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bank Account - User goes to ‘Connect manually’ flow after ‘Start Over’ in offline.

What is root cause of that problem?

Whenever there is a change in network status, we call the fetchData method which opens the correct reimbursement page based on the step by calling BankAccount.openReimbursementAccountPage() method.

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js

Lines 118 to 121 in 5100743

	componentDidUpdate(prevProps) {
	if (prevProps.network.isOffline && !this.props.network.isOffline) {
	this.fetchData();
	}

Now if the user clicked on Start over option while being offline the this.props.reimbursementAccount will have a pending action of delete and when the user becomes online again the fetchData method will try to open reimbursement page based on this.props.reimbursementAccount that has a pending action of delete and the result contains BankAccountStep as currentStep and manual as a subStep which causes the screen to navigate to manual bank account screen.

So the problem is trying to fetch data with this.props.reimbursementAccount that is about to get deleted.

What Changes do you think we should make in order to solve the problem?

If reimbursementAccount has a delete pending action, there is no need to call fetchData when the network status changes from offline to online because the reimbursementAccount data will be deleted.

This can be achieved by adding a condition that checks if prevProps.reimbursementAction has a delete pending action and if it has, prevent fetchData from being called in componentDidUpdate() method as shown below.

if (prevProps.network.isOffline && !this.props.network.isOffline 
  && prevProps.reimbursementAccount.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE) {
        this.fetchData();
}

• This also ensures that we don't make unnecessary api call to the backend by preventing fetchData() from calling OpenReimbursementAccountPage

What alternative solutions did you explore? (Optional)

None

Result

working well after the fix:

user-goes-to-manual-step-offline.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01aeed1cce3edf8b8d

[melvin-bot]

Current assignee @arielgreen is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[arielgreen]

Offers sent in Upwork.

[arielgreen]

Reassigning, OOO tomorrow/Monday.

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.20-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix - bank account user goes to connect manually flow after start over offline #19491

If no regressions arise, payment will be issued on 2023-06-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@johncschuster / @arielgreen] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/291261

[johncschuster]

I have issued payment. @mananjadhav, do you believe the steps in the OP are sufficient for the regression test, or do we need something else?

[mananjadhav]

@johncschuster Just confirming isn't it eligible for the timeline bonus? Next Tests in PR are good enough for the regression test. @flodnv wdyt?

[flodnv]

I think it sounds good 👍

[johncschuster]

@mananjadhav Hmm, I thought the PR was merged in 7 days. Am I wrong? I'm happy to issue a bonus, I just thought it wasn't eligible.

[mananjadhav]

@mananjadhav Hmm, I thought the PR was merged in 7 days. Am I wrong? I'm happy to issue a bonus, I just thought it wasn't eligible.

@johncschuster Because the checklist was completed within 3 days. Generally we focus on when the checklist is completed without further changes.

[johncschuster]

Got it. Thank you for clearing that up! I'll get those bonuses taken care of. While I'm working on that, can you finish out the BZ checklist above, @mananjadhav?

Thank you!

[mananjadhav]

Thanks @johncschuster.

About the checklist yeah, I couldn't trace the offending PR. I saw this PR added the network offline check to fetch the data on switching the network. But I couldn't pinpoint if we did support offline behavior that time. The PR seems to be more than a year old.

[johncschuster]

Ok! Bonuses have been issued 🙌

Thanks for calling that out, @mananjadhav!

I'll get a regression test GH going shortly.

[johncschuster]

Regression test GH is live! I think we're good to close this one. 👍