[HOLD for payment 2023-05-25] [$1000] Auto-suggester throws console error when scrolling through less than 5 options

[puneetlath]

If you only have one option and you use the arrow keys to scroll through the list, you see a console error. We should fix this.

bug0.mov

@0xmiroslav did you want to take this one?

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d83c4180a356aaa0
• Upwork Job ID: 1656674431586570240
• Last Price Increase: 2023-05-11

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Auto suggester throws console error when selecting an option through keyboard

What is the root cause of that problem?

The root cause is that we're calculating an incorrect getMaxArrowIndex here.

This error occurs on emoji selection as well because we're using the same function there as well.

What changes do you think we should make in order to solve the problem?

We need to change the getMaxArrowIndex function to:

const getMaxArrowIndex = (numRows, isAutoSuggestionPickerLarge) => {
    const maxToUse = isAutoSuggestionPickerLarge ? CONST.AUTO_COMPLETE_SUGGESTER.MAX_AMOUNT_OF_ITEMS : CONST.AUTO_COMPLETE_SUGGESTER.MIN_AMOUNT_OF_ITEMS;
    if (numRows > maxToUse) {
        return maxToUse - 1;
    }

    return numRows - 1;
};

What alternative solutions did you explore? (Optional)

None

@puneetlath I'm not expecting to get paid here. Feel free to assign this to @0xmiroslav if he wants to take this over. It's really late here and I can't seem to sleep so just trying to help.

[0xmiros]

@0xmiroslav did you want to take this one?

@puneetlath yes I'd like to

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d83c4180a356aaa0

[melvin-bot]

Current assignees @puneetlath and @abekkala are eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[melvin-bot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @0xmiroslav You have been assigned to this job by @puneetlath!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[puneetlath]

@abekkala I'm going to take this one with @0xmiroslav

[melvin-bot]

📣 @Santhosh-Sellavel You have been assigned to this job by @puneetlath!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[puneetlath]

@0xmiroslav mind giving an ETA on when you'll have the PR up?

[0xmiros]

PR will be ready in a few hrs

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.15-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix stale focusedIndex when maxIndex changed in ArrowKeyFocusManager #18955

If no regressions arise, payment will be issued on 2023-05-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter @0xmiroslav
• Contributor that fixed the issue @0xmiroslav
• Contributor+ that helped on the issue and/or PR @Santhosh-Sellavel

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel / @0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
• [@Santhosh-Sellavel / @0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Santhosh-Sellavel / @0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Santhosh-Sellavel / @0xmiroslav] Determine if we should create a regression test for this bug.
• [@Santhosh-Sellavel / @0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Santhosh-Sellavel]

@0xmiroslav I believe you are aware of the PR which caused this one can you link it if you know, thanks!

[0xmiros]

This bug first introduced while implementing emoji suggester in #14686

[0xmiros]

@puneetlath I think I am also eligible for bug reporting bonus as it already happened before mentions-suggester PR which I reviewed.

[puneetlath]

Yep! I included reporting bonus as a milestone in the contract I sent you.

[Santhosh-Sellavel]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel / @0xmiroslav] The PR that introduced the bug has been identified. Link to the PR: Static emoji autosuggestion  #14686
• [@Santhosh-Sellavel / @0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Static emoji autosuggestion  #14686 (comment)
• [@Santhosh-Sellavel / @0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A this should be caused based on checklist
• [@Santhosh-Sellavel / @0xmiroslav] Determine if we should create a regression test for this bug. N/A
• [@Santhosh-Sellavel / @0xmiroslav] If we decide to create a regression test for the bug, please propose the [regression test] (https://github.com/Expensify/App/blob/main/contributingGuides/REGRESSION_TEST_BEST_PRACTICES.md) steps to ensure the same bug will not reach production again. N/A
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@puneetlath do you agree with above, let me know thanks!

[puneetlath]

Looks good to me!

[puneetlath]

All paid. Thanks for the quick work y'all!