Pressing ESC key on "start over" confirmation modal closes "workspace settings"

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to the Settings > Workspaces > Connect bank account
2. Click on start over button
3. After that press Esc

Expected Result

When the 'Start Over' button is clicked, pressing the 'Esc' then just 'Are you sure' modal should be close

Actual Result

When the 'Start Over' button is clicked, pressing the 'Esc' key exits the 'Workspace Connect' bank account settings instead of closing the 'Are you sure?' modal.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.13.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-05-10.21-16-59.mp4

Recording.558.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683735687149239

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pressing ESC key on "start over" confirmation modal closes the "workspace settings" RHN

What is the root cause of that problem?

In the BaseModal here we're setting Modal.willAlertModalBecomeVisible only in the componentDidUpdate method depending on the isVisible prop. The value of willAlertModalBecomeVisible property is being used here to either dismiss the navigation modal or to keep it visible.

The above essentially means that if we'll unmount and remount the whole modal for visibility, the willAlertModalBecomeVisible will never be set to true since the Modal had the isVisible prop set to true since the beginning and the componentDidUpdate would never fire. This would cause the condition here to be false, thus closing the navigation modal.

We're currently unmounting and re-mounting the Modal at 3 places. We're doing this here, here and here. We're also always un-mounting the context menu.

What changes do you think we should make in order to solve the problem?

We need to add the following here:

    if(props.isVisible)
        Modal.willAlertModalBecomeVisible(true);

When the component un-mounts, we also need to add this here:

   // Probably a super edge case but we can add the below if condition to be super safe.
     if (props.isVisible)
        Modal.willAlertModalBecomeVisible(false);

What alternative solutions did you explore? (Optional)

At all of the three places mentioned above, we should not conditionally render the Modal. Rather, we should allow it to render and instead control the visibility by the isVisible prop defined here. We need to set the value of isVisible prop to: props.reimbursementAccount.shouldShowResetModal.

[dukenv0307]

This issue maybe duplicated this one

[s77rt]

Indeed a dupe. @bfitzexpensify Let's close this one.