Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] [HOLD for payment 2023-05-25] Update LHN/Header for threads to be consistent with design doc #18863

Closed
stitesExpensify opened this issue May 12, 2023 · 10 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@stitesExpensify
Copy link
Contributor

stitesExpensify commented May 12, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Create a thread

Expected Result:

header/lhn should look like this
2023-05-12_13-21-23

Actual Result:

Header / lhn looks like this

2023-05-12_13-21-10

Workaround:

Usable, but bad UI

Platforms:

Which of our officially supported platforms is this issue occurring on?
all

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d6dfbcc4cfe1d0e3
  • Upwork Job ID: 1663248548043726848
  • Last Price Increase: 2023-05-29
@stitesExpensify stitesExpensify added the Daily KSv2 label May 12, 2023
@stitesExpensify stitesExpensify self-assigned this May 12, 2023
@melvin-bot melvin-bot bot added Overdue Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Overdue Daily KSv2 labels May 15, 2023
@melvin-bot melvin-bot bot changed the title Update LHN/Header for threads to be consistent with design doc [HOLD for payment 2023-05-25] Update LHN/Header for threads to be consistent with design doc May 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 18, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 18, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.15-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-05-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels May 24, 2023
@stitesExpensify stitesExpensify added the External Added to denote the issue can be worked on by a contributor label May 29, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-05-25] Update LHN/Header for threads to be consistent with design doc [$1000] [HOLD for payment 2023-05-25] Update LHN/Header for threads to be consistent with design doc May 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 29, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01d6dfbcc4cfe1d0e3

@melvin-bot
Copy link

melvin-bot bot commented May 29, 2023

Triggered auto assignment to @bfitzexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@stitesExpensify stitesExpensify added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor labels May 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 29, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

@melvin-bot
Copy link

melvin-bot bot commented May 29, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 29, 2023

Current assignee @stitesExpensify is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot removed Help Wanted Apply this label when an issue is open to proposals by contributors Overdue labels May 29, 2023
@stitesExpensify
Copy link
Contributor Author

Sorry for the pings everyone, I should have made this internal from the beginning. @bfitzexpensify can we please pay the C+ $1000 (@rushatgabhane )

@rushatgabhane
Copy link
Member

rushatgabhane commented May 29, 2023

Thanks!
applied to job using profile - https://www.upwork.com/freelancers/~01212e8255b02ae924

@bfitzexpensify bfitzexpensify self-assigned this May 30, 2023
@parasharrajat parasharrajat removed their assignment May 30, 2023
@bfitzexpensify
Copy link
Contributor

Paid out and ended contract. Think we're all done here now, going to close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

5 participants