Settings - Share code - Share button is non functional

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #18636

Action Performed:

1. Launch the app and login,
2. Go to Personal Profile Settings menu
3. Tap the "Show QR Code" button under your profile name and picture
4. Verify that you see two menu items: Share and Download
5. Tap on Share button

Expected Result:

Share button is functional

Actual Result:

Share button is non functional

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.14.4

Reproducible in staging?: Yes

Reproducible in production?: New feature

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team and @Natnael-Guchima

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0154212e434bfba80a
• Upwork Job ID: 1660439185885417472
• Last Price Increase: 2023-05-22

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[therealsujitk]

This is not a bug, It actually copies the link to clipboard, perhaps it shouldn't be called Share or, maybe a feedback message saying the link has been copied to clipboard? or maybe it's called Share because the authors are planning to change the functionality in future.

[Natnael-Guchima]

This is not a bug, It actually copies the link to clipboard, perhaps it shouldn't be called Share or, maybe a feedback message saying the link has been copied to clipboard? or maybe it's called Share because the authors are planning to change the functionality in future.

According to a slack discussion here, I think the plan is to go with changing the arrow icon with copy to clipboard icon.

[Natnael-Guchima]

This issue seems to be fixed by this PR. But it is not appropriately linked to the fixing PR. Linking it to the fixing PR might be a good idea to track the progress of this report.

Here is the slack report of this GH issue for more context

cc: @mountiny @robertjchen @kadiealexander

[kadiealexander]

Thanks for flagging that PR @Natnael-Guchima, this behaviour is now fixed:

2023-05-19_13-12-46.mp4

Closing this issue!

[Natnael-Guchima]

You are welcome @kadiealexander. I am not paid for the original reporting though. I think the discussion to change the icon from an arrow icon to copy clipboard was first triggered by my report here https://expensify.slack.com/archives/C049HHMV9SM/p1684154588458859?thread_ts=1684154588.458859&cid=C049HHMV9SM. You can go through the report and the replies for evidence.

Thanks.

[mountiny]

@kadiealexander yep I think @Natnael-Guchima was first to note this bug so we should pay them for reporting it. Reopening to handle the payment. thank you!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0154212e434bfba80a

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mollfpr (Internal)

[kadiealexander]

Added the internal label to spin up an Upwork job.

[kadiealexander]

@Natnael-Guchima sent you an offer, please let me know when you accept.

[Natnael-Guchima]

I have accepted the offer, @kadiealexander. Thanks.

[kadiealexander]

Paid! Thanks @Natnael-Guchima