PAY 06/01 'Report no longer exists' error is displayed when trying to chat with a phone number using the share code URL

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Sign in with your phone number
2. Go to Settings > Share code
3. Click Copy URL to clipboard
4. Next, sign in with some other account
5. Paste and go to the copied URL
6. Click on Message

Expected Result:

No error is displayed

Actual Result:

'Report no longer exists' error is displayed

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.16-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-18.at.12.19.23.AM.mov

Recording.684.mp4

Expensify/Expensify Issue URL:
Issue reported by: @adeel0202
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684351944659109

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Prince-Mendiratta]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In this issue, we can notice that the QR code share URL is not working with phone numbers.

What is the root cause of that problem?

We directly use the mobile number in the URL for the QR code, leading to this error when it should instead be URL encoded form, leading to mismatched login.

App/src/pages/ShareCodePage.js

Line 42 in 5fab2de

const url = isReport ? `${CONST.NEW_EXPENSIFY_URL}r/${this.props.report.reportID}` : `${CONST.NEW_EXPENSIFY_URL}details?login=${this.props.session.email}`;

What changes do you think we should make in order to solve the problem?

We need to use the encodeURIComponent function to URL encode the session.email.

What alternative solutions did you explore? (Optional)

None

[Prince-Mendiratta]

Actually, should be solved by #19076

[bfitzexpensify]

Checking in with the contributor providing the solution over in #19076 to confirm this problem will be solved via that solution

[bfitzexpensify]

OK, contributor confirmed, we can close this out.

[adeel0202]

Hi @bfitzexpensify, would I not be compensated for reporting once this issue gets fixed via that solution?

[bfitzexpensify]

Hi @adeel0202, yes, I think that is reasonable. I invited you to a reporting job on Upwork. I've subscribed to #19076 and will pay out once that's complete.

[bfitzexpensify]

Going to reopen this to help me monitor that payment, too.

[adeel0202]

Thanks. I've accepted the invitation.

[bfitzexpensify]

#19076 has been merged, waiting for 7 days post deployment to prod

[bfitzexpensify]

Payment on 06/01

[bfitzexpensify]

Payment on 6/1, not overdue

[gadhiyamanan]

@bfitzexpensify this issue is not eligible for reporting bonus as per #19076 (comment)
cc: @tjferriss

[bfitzexpensify]

Thanks for letting me know @gadhiyamanan. Going to close this issue out.

[adeel0202]

@bfitzexpensify, I was already hired on Upwork for reporting. Can you please end that contract too and also add the remarks that this job is not required anymore? I don't want that contract to negatively impact my profile.

[bfitzexpensify]

Sure @adeel0202, I've done that now

[adeel0202]

Thanks.