Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LOW] [P2P] Allow for QR codes to be easily saved or copied on all platforms #19834

Open
2 of 6 tasks
MitchExpensify opened this issue May 30, 2023 · 80 comments
Open
2 of 6 tasks

[LOW] [P2P] Allow for QR codes to be easily saved or copied on all platforms #19834

MitchExpensify opened this issue May 30, 2023 · 80 comments
Assignees
@robertjchen @chrispader
Labels
Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 NewFeature Something to build that is a new item.

Comments

@MitchExpensify
Copy link
Contributor

MitchExpensify commented May 30, 2023 •
edited by melvin-bot bot
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

On desktop:

  1. Click any room header
  2. Click "Share code"
  3. Right click the QR code

Expected Result:

Have the option to "Save image as", "Copy image", or Download the QR code image

Actual Result:

No option to easily save or copy the QR code image

Workaround:

Copy or save the QR code image on mobile

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.3.19-7
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): All
Notes/Photos/Videos:

image image

Expensify/Expensify Issue URL:
Issue reported by: @MitchExpensify
Slack conversation: Internal convo: https://expensify.slack.com/archives/C03U7DCU4/p1685041725518029, #bug-zero convo tbd

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013d2f9dd751374d8e
  • Upwork Job ID: 1663602988972146688
  • Last Price Increase: 2023-05-30
@MitchExpensify MitchExpensify added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 30, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 30, 2023

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot

This comment was marked as off-topic.

Sign in to view
@robertjchen robertjchen added the Internal Requires API changes or must be handled by Expensify staff label May 30, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 30, 2023

Job added to Upwork: https://www.upwork.com/jobs/~013d2f9dd751374d8e

@melvin-bot
Copy link

melvin-bot bot commented May 30, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mollfpr (Internal)

@JmillsExpensify
Copy link

Great point reminder that we should always optimize for cross-platform everywhere!

@robertjchen
Copy link
Contributor

@chrispader Would you possibly have some free cycles to look into adding QR code download for Web? I recall you mentioning that we may have to make some upstream changes to the library? 🤔

@chrispader
Copy link
Contributor

Yes, i can take a look at that! :)

@chrispader
Copy link
Contributor

chrispader commented May 31, 2023 •
edited
Loading

Yes, so the react-native-view-shot library currently doesn't work on web, so i'm gonna investigate the problem and open an upstream PR. We could probably also open a separate PR in our an own fork?

@robertjchen
Copy link
Contributor

yup, sounds like a plan! 🙇

@robertjchen robertjchen added Weekly KSv2 and removed Daily KSv2 labels Jun 2, 2023
@robertjchen robertjchen assigned chrispader and unassigned mollfpr Jun 2, 2023
@chrispader
Copy link
Contributor

chrispader commented Jun 6, 2023 •
edited
Loading

Working on this issue in the upstream library (PR)

@chrispader
Copy link
Contributor

chrispader commented Jun 7, 2023 •
edited
Loading

The PR is working and making screenshots on web works now too, though there is one problem.

The library that is creating a canvas from the html canvas doesn't have access to the profile picture/avatar image that is received from CloudFront because of CORS policy regulations.

Is there any way to add these CORS headers to the S3 Bucket/AWS or would this violate Expensify's security?

cc @robertjchen

@chrispader
Copy link
Contributor

Which leads to images like this:

Christoph Pader-ShareCode (8)

@chrispader chrispader mentioned this issue Jun 7, 2023
Closed
57 tasks
@chrispader
Copy link
Contributor

The Expensify/App PR for this feature is here

@robertjchen
Copy link
Contributor

Yep, I'll look into the CORs changes!

@melvin-bot
Copy link

melvin-bot bot commented Jun 13, 2023

@robertjchen @chrispader this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 13, 2023
@chrispader
Copy link
Contributor

@robertjchen are there any updates on the CORS changes?

@melvin-bot melvin-bot bot added the Overdue label Jan 24, 2024
@greg-schroeder
Copy link
Contributor

This has been sitting forever - sounds like we classified it as a nice to have? Should this still be listed as Critical or even open at all?

@melvin-bot melvin-bot bot removed the Overdue label Jan 26, 2024
@robertjchen
Copy link
Contributor

Changed to Low - P2P per https://expensify.slack.com/archives/C05RECHFBEW/p1705954738163119?thread_ts=1705712907.222529&cid=C05RECHFBEW

@robertjchen
Copy link
Contributor

Also updating assignments for cleaner K2s and since this is now an Internal task.

@aimane-chnaif aimane-chnaif mentioned this issue Feb 21, 2024
Merged
50 tasks
@melvin-bot melvin-bot bot added the Overdue label Feb 27, 2024
@robertjchen
Copy link
Contributor

Now prioritized under #vip-split

@melvin-bot melvin-bot bot removed the Overdue label Feb 28, 2024
@arielgreen arielgreen changed the title Allow for QR codes to be easily saved or copied on all platforms [LOW] [P2P] Allow for QR codes to be easily saved or copied on all platforms Mar 4, 2024
@robertjchen
Copy link
Contributor

Revisiting this later this week!

@robertjchen
Copy link
Contributor

Was focused on pushing out wave items, revisiting this this week for sure!

@robertjchen
Copy link
Contributor

Tackling this week, moved https://github.com/Expensify/Expensify/issues/300566 to weekly

@melvin-bot melvin-bot bot added the Overdue label May 10, 2024
@robertjchen
Copy link
Contributor

robertjchen commented May 14, 2024 •
edited
Loading

https://github.com/Expensify/Expensify/issues/300566 to be addressed first

@melvin-bot melvin-bot bot removed the Overdue label May 14, 2024
@robertjchen
Copy link
Contributor

paused for now

@robertjchen
Copy link
Contributor

no update

@melvin-bot melvin-bot bot added the Overdue label Aug 7, 2024
@robertjchen
Copy link
Contributor

no update

@melvin-bot melvin-bot bot removed the Overdue label Aug 14, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 16, 2024
@robertjchen
Copy link
Contributor

no update

@melvin-bot melvin-bot bot removed the Overdue label Sep 16, 2024
@lakchote lakchote mentioned this issue Sep 27, 2024
Merged
60 tasks
@melvin-bot melvin-bot bot added the Overdue label Oct 17, 2024
@robertjchen
Copy link
Contributor

no update

@melvin-bot melvin-bot bot removed the Overdue label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertjchen robertjchen

@chrispader chrispader

Labels
Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 NewFeature Something to build that is a new item.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@JmillsExpensify @shawnborton @robertjchen @chrispader @mollfpr @greg-schroeder @MitchExpensify @arielgreen @bfitzexpensify @Christinadobrzyn