[HOLD for payment 2023-06-21] [$1000] DEV: console error on opening Share code of thread

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. go to any chat
2. send any message
3. click on reply in thread option
4. click on header of thread to open details page
5. click on share code

Expected Result:

should not show any console error

Actual Result:

shows console error

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [] Android / native
• [] Android / Chrome
• [] iOS / native
• [] iOS / Safari
• MacOS / Chrome / Safari
• [] MacOS / Desktop

Version Number: 1.3.20.2
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-30.at.2.50.20.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation:
https://expensify.slack.com/archives/C049HHMV9SM/p1685430101536709
View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016f17d9321b19bf9c
• Upwork Job ID: 1666644239370522624
• Last Price Increase: 2023-06-08

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[situchan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Console error on Share code page from thread chat

What is the root cause of that problem?

string && <View /> here:

App/src/components/QRShare/index.js

Lines 74 to 75 in d661708

	{this.props.subtitle && (
	<Text

This was introduced in #18636.
This checklist item was skipped during PR review:

• I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.

What changes do you think we should make in order to solve the problem?

wrap with _isEmpty which is boolean:

!_.isEmpty(this.props.subtitle) &&

[sophiepintoraetz]

This has been resolved as a part of #18968 and the reporter paid. I am unable to reproduce.

[gadhiyamanan]

@sophiepintoraetz this is different issue and reproducible in dev when user open share code of thread

[sophiepintoraetz]

@gadhiyamanan I am unable to reproduce it - as mentioned before so there needs to be clearer reproduction steps in order to progress this through.

2023-06-02_17-38-36.mp4

[gadhiyamanan]

steps are the same but it is reproducible only in the dev(main branch). I think you are checking in staging or Production that's why you are not able to reproduce
cc: @sophiepintoraetz

Screen.Recording.2023-06-02.at.11.23.20.AM.mov

[gadhiyamanan]

Bump @sophiepintoraetz ^^

[sophiepintoraetz]

@robertjchen - this is on dev and I think introduced from #18630 - can you reproduce here? 🙏

[robertjchen]

I was able to reproduce this in local dev 👍

[robertjchen]

It was not introduced by #18630 since that feature came out prior to threads, and so this is an isolated bug.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016f17d9321b19bf9c

[melvin-bot]

Current assignee @sophiepintoraetz is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

Current assignee @robertjchen is eligible for the External assigner, not assigning anyone new.

[robertjchen]

The fix I came to locally matches @situchan 's proposal (though I used !! instead of !_.isEmpty). Which approach is better? 🤔

[situchan]

Either approach is fine but I recently noticed that PR reviewers recommend to use !_.isEmpty instead of !!.

[robertjchen]

ok, perfect! cc: @mananjadhav for 👍 on proposed changes

[melvin-bot]

🎯 ⚡️ Woah @mananjadhav / @situchan, great job pushing this forwards! ⚡️

The pull request got merged within 2 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @situchan got assigned: 2023-06-08 04:05:40 Z
• when the PR got merged: 2023-06-08 16:54:43 UTC

On to the next one 🚀

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[sophiepintoraetz]

@dylanexpensify - I just need you to action the payments once the regression period has passed (PR still going through QA so I think that will populate in the GH soon)
@gadhiyamanan - $250
@mananjadhav and @situchan = $1500

Job is here! https://www.upwork.com/jobs/~016f17d9321b19bf9c

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.27-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix left part of conditional rendering not boolean on QRShare component #20444

If no regressions arise, payment will be issued on 2023-06-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sophiepintoraetz / @dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sophiepintoraetz]

@gadhiyamanan and @situchan - contracts are with you! @mananjadhav - if you can go through the BZ checklist, I'll be able to release payment to you too.

[gadhiyamanan]

@sophiepintoraetz accepted, thanks!

[situchan]

@sophiepintoraetz the offer is not available anymore

[mananjadhav]

The first instance when we added the subtitle prop was in this PR.

I've added this comment on the offending PR.

I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && .

We already have a checklist item here but we missed the particular condition in the code. I don't think any further updates are required and I don't think we need a regression test either.

cc - @sophiepintoraetz @robertjchen

[sophiepintoraetz]

Thanks @mananjadhav - releasing payment!

We also have an item in the checklist which was marked but we missed highlighting this one.

How did we miss highlighting it? Does it mean someone marked it off but it wsn't actually completed?

@situchan - sorry! I swear I sent the offer to you but I think Upwork was messing with me. You should have a new offer now.

[sophiepintoraetz]

Payments all set so closing!