[HOLD for payment 2023-06-29] Web - Group chat - "Invalid email" error message appears when creating a group DM with Concierge

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Log in to any account
2. Click Fab > New group
3. Select any random email and concierge as members
4. Click "Create Group"

Expected Result:

Group is created successfully

Actual Result:

Invalid email error message appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.29.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6098712_Recording__1023.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[arosiclair]

https://github.com/Expensify/Web-Expensify/pull/37753 appears to be the root cause for this as well. We're passing empty string as the login for concierge because the client doesn't have it:

FWIW, I'm not sure you're supposed to be able to make a group chat with concierge

[Beamanator]

Looks like we DO want to be able to create group chats w/ concierge, but not some other expensify emails: #8586

[Beamanator]

as of right now now I'm unable to reproduce in main / main / main

[Beamanator]

Here's some logs from when I reproduced in main / staging

• Notice command: 'OpenReport' reportID: '2466172879786697' emailList: 'alexbeaman+1@expensifail.com,'

We somehow sent a completely empty email in emailList 🤔

[Beamanator]

So ya technically this is fixed for starting group chats w/ Concierge - now we're chatting about starting group chats w/ other people who you don't have their login

[jasperhuangg]

now we're chatting about starting group chats w/ other people who you don't have their login

This is fixed by #21159, since you can't even start group chats with people if you don't have their logins now.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.29-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Only consider personal details with logins set in OptionsListUtils.getOptions #21159

If no regressions arise, payment will be issued on 2023-06-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[bondydaa]

removing blocker as this is fixed for group chats with concierge. if there is a new bug about group dms for different cases then lets spin up a new issue.

[puneetlath]

I just tested a few different scenarios of creating group chats on staging and they all seemed to work.

[jasperhuangg]

Let's close this out then?

[Beamanator]

Agreed, no payment due here so we can close 👍

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.30-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Only consider personal details with logins set in OptionsListUtils.getOptions #21159

If no regressions arise, payment will be issued on 2023-06-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty