Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$1000] Takes longer to load the content in the app #21125

Closed
1 of 6 tasks
kavimuru opened this issue Jun 20, 2023 · 39 comments
Closed
1 of 6 tasks

[$1000] Takes longer to load the content in the app #21125

kavimuru opened this issue Jun 20, 2023 · 39 comments
Assignees
@hannojg @fedirjh @zanyrenney
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Needs Reproduction Reproducible steps needed

Comments

@kavimuru
Copy link

kavimuru commented Jun 20, 2023 •
edited by melvin-bot bot
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Open app
  2. Tap search

Expected Result:

Search should load immediately

Actual Result:

Takes longer up to 3 seconds to load.
it's because account has a lot of content, but still, 3000ms is not great.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number:
Reproducible in staging?: Needs reproduction (Not able to reproduce for me)
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686617915136649

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010b56d48efbcb92a0
  • Upwork Job ID: 1671884565598355456
  • Last Price Increase: 2023-06-22
@kavimuru kavimuru added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Jun 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 20, 2023

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 20, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@kavimuru kavimuru changed the title Takes longer to load the content when opening the app Takes longer to load the content in the app Jun 20, 2023
@zanyrenney
Copy link
Contributor

Cross posted this to expensify open source: https://expensify.slack.com/archives/C01GTK53T8Q/p1687281235653819

@zanyrenney
Copy link
Contributor

Not able to reproduce.

@zanyrenney
Copy link
Contributor

zanyrenney commented Jun 22, 2023 •
edited
Loading

Have bumped this conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1687436778559249?thread_ts=1687281235.653819&cid=C01GTK53T8Q

@hannojg
Copy link
Contributor

hannojg commented Jun 22, 2023 •
edited
Loading

Hey, I am able to reproduce that. I am from Margelo and would like to work on this issue (I am already running a performance audit anyways, and the search flow is part of that).

(Will post a proposal shortly)

@zanyrenney
Copy link
Contributor

Hey, I am heading OOO shortly, so assigning another bug0 team member to help watch over this issue whilst I am OOO. thank you!

@zanyrenney zanyrenney removed the Bug Something is broken. Auto assigns a BugZero manager. label Jun 22, 2023
@zanyrenney zanyrenney removed their assignment Jun 22, 2023
@zanyrenney zanyrenney added the External Added to denote the issue can be worked on by a contributor label Jun 22, 2023
@melvin-bot melvin-bot bot changed the title Takes longer to load the content in the app [$1000] Takes longer to load the content in the app Jun 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 22, 2023

Job added to Upwork: https://www.upwork.com/jobs/~010b56d48efbcb92a0

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 22, 2023

Triggered auto assignment to @sophiepintoraetz (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 22, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

@zanyrenney zanyrenney added Bug Something is broken. Auto assigns a BugZero manager. and removed Help Wanted Apply this label when an issue is open to proposals by contributors labels Jun 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 22, 2023

Current assignee @sophiepintoraetz is eligible for the Bug assigner, not assigning anyone new.

@melvin-bot

This comment was marked as duplicate.

Sign in to view
@sophiepintoraetz
Copy link
Contributor

sophiepintoraetz commented Jun 25, 2023 •
edited
Loading

Keeping you assigned as per the SO, Zany! (In case this goes on until your return)

@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

📣 @hannojg You have been assigned to this job by @puneetlath!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@zanyrenney
Copy link
Contributor

Awesome, thanks @hannojg

@hannojg
Copy link
Contributor

hannojg commented Jul 11, 2023 •
edited
Loading

@zanyrenney

@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

@hannojg @fedirjh @zanyrenney this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@zanyrenney
Copy link
Contributor

Thanks @hannojg - if you are working on this in that issue, should we close this one out? let me know your suggestion please!

@melvin-bot melvin-bot bot removed the Overdue label Jul 14, 2023
@hannojg
Copy link
Contributor

hannojg commented Jul 14, 2023

I would leave this one open as it better describes the issue, and the issue I mentioned might not be enough to completely get rid of this issue. That's something we have to test once them mentioned issue is solved. So I'd hold this one on hold for the mentioned issue.

@melvin-bot melvin-bot bot added the Overdue label Jul 17, 2023
@zanyrenney
Copy link
Contributor

Okay, that makes sense, thank you @hannojg

@melvin-bot melvin-bot bot removed the Overdue label Jul 17, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 18, 2023

@hannojg @fedirjh @zanyrenney this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

  • Decide whether any proposals currently meet our guidelines and can be approved as-is today
  • If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

@melvin-bot melvin-bot bot added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor labels Jul 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 18, 2023

Current assignee @fedirjh is eligible for the Internal assigner, not assigning anyone new.

@hannojg
Copy link
Contributor

hannojg commented Jul 19, 2023

The Onyx change is of larger nature and is still actively being worked on here:

@melvin-bot melvin-bot bot added the Overdue label Jul 21, 2023
@zanyrenney
Copy link
Contributor

Still on hold for this issue: Expensify/react-native-onyx#280

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 24, 2023
@zanyrenney
Copy link
Contributor

There are still updates being made to Expensify/react-native-onyx#280

@melvin-bot melvin-bot bot removed the Overdue label Jul 27, 2023
@hannojg
Copy link
Contributor

hannojg commented Jul 27, 2023

The PR just got merged and we are working on getting it into the app:

@hannojg
Copy link
Contributor

hannojg commented Jul 27, 2023 •
edited
Loading

The aforementioned PR fixes the issue, as also reported by testers (David). Video:
(Notice that there is no blocking in opening the search page and it opens right away. This is on a really slow physical android device):

rn_image_picker_lib_temp_199346d5-922d-4e64-8d47-88c1a0f0fa3b.mp4

@melvin-bot melvin-bot bot added the Overdue label Jul 31, 2023
@zanyrenney
Copy link
Contributor

Hey @hannojg would you mind being a bit more clear please?

The aforementioned PR fixes the issue, as also reported by testers (David)

Do you mean the linked PR #23749 fixes this issue? or that now that issue is merged, we can resume work on this? Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Jul 31, 2023
@hannojg
Copy link
Contributor

hannojg commented Jul 31, 2023

It means that the linked PR #23749 fixed the issue, yes! 😊

@zanyrenney
Copy link
Contributor

Brilliant! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hannojg hannojg

@fedirjh fedirjh

@zanyrenney zanyrenney

Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Needs Reproduction Reproducible steps needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@hannojg @fedirjh @sophiepintoraetz @kavimuru @zanyrenney