[HOLD for payment 2023-08-17] Add comment/number of requests to IOUReport display

[Gonals]

Problem
Currently, we don't display any additional info on request reports:

Solution
Let's display the Request comment when there is a single request in the report, or the Number of requests if there's more than one. To avoid loading all actions when displaying the report preview, we'll need to add this info on the backend. Ideally on the reportAction, as two new pieces: numberOfRequests and lastRequestComment. We can then display them on the frontend

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d1f7e066ce82b8a0
• Upwork Job ID: 1671448886814179328
• Last Price Increase: 2023-06-21

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d1f7e066ce82b8a0

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @abdulrahuman5196 (Internal)

[melvin-bot]

@JmillsExpensify, @Gonals, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Gonals]

I'll be back on this soon!

[melvin-bot]

@JmillsExpensify, @trjExpensify, @Gonals, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@JmillsExpensify, @trjExpensify, @Gonals, @abdulrahuman5196 Eep! 4 days overdue now. Issues have feelings too...

[abdulrahuman5196]

Not overdue.
@Gonals Gentle bump.

[Gonals]

Working on it. There was a revert

[melvin-bot]

@JmillsExpensify, @trjExpensify, @Gonals, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[JmillsExpensify]

@trjExpensify Didn't we at one point in planning decide to review the number of requests in the report preview?

[Gonals]

@trjExpensify Didn't we at one point in planning decide to review the number of requests in the report preview?

Sorry, what to do you mean? 😅

[trjExpensify]

Yeah, I'm not sure. Are you talking about the reply count in threads not including requests/sys messages, only comments or something in the future? 🤔

For the report preview, I thought the logic carried into Scan Receipts was:

One request report:

• merchant if value > else comment > else blank if no merchant or comment

multi request report:

• number of requests on the report.

[Gonals]

Final PR in review! (We can add the merchant for Receipts later. Comment/Number of requests for Manual requests is what we currently have)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Show comment/requests in report preview #23651

If no regressions arise, payment will be issued on 2023-08-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
• [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abdulrahuman5196] Determine if we should create a regression test for this bug.
• [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify / @trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abdulrahuman5196]

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

New Feature

Determine if we should create a regression test for this bug.

Yes

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Log into your account in newdot
2. Request money from someone else and add a comment while doing so
3. Confirm the comment immediately shows in the request preview
4. Request money again from the same person.
5. Confirm that, instead of the comment, the number of requests show immediately in request preview.

[trjExpensify]

Alrighty, $1000 due to @abdulrahuman5196 for the C+ review of the internal PR. Offer sent!

We'll take care of the regression test in a wider update.

[trjExpensify]

Settled up!