[HOLD for payment 2023-10-30] [HOLD #25714] Split bill - App crashes when splitting bill in group with both expensifail and gmail accounts #21268

lanitochka17 · 2023-06-21T20:59:33Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found when executing PR #20838

Action Performed:

Login to NewDot
Create a group with several gmail and expensifail accounts
Go to created group chat
Tap + and create a split bill for the whole group

Expected Result:

Successful Split Bill

Actual Result:

App crashes (Android)
App freezes (Web, mWeb)
Error message when creating split bill (iOS)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.30.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

video_13.mp4

Pronin.crash.2106.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

OSBotify · 2023-06-21T21:01:50Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2023-06-21T21:01:54Z

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

luacmartins · 2023-06-21T22:13:08Z

@aldo-expensify if it helps, I see these logs in crashlytics:

Non-fatal Exception: io.invertase.firebase.crashlytics.JavaScriptError: array list[1] is not type String
       at .stringListFromIterable(address at index.android.bundle:1:5688527)
       at .anonymous(address at index.android.bundle:1:5690123)
       at .arrayToString(address at index.android.bundle:1:1847665)
       at .createSplitsAndOnyxData(address at index.android.bundle:1:2878809)
       at .splitBill(address at index.android.bundle:1:2881501)
       at .anonymous(address at index.android.bundle:1:2671772)
       at .onConfirm(address at index.android.bundle:1:2672957)
       at .anonymous(address at index.android.bundle:1:2767405)
       at .onPress(address at index.android.bundle:1:2767806)
       at .onPress(address at index.android.bundle:1:2770537)
       at .onPress(address at index.android.bundle:1:1725618)
       at .anonymous(address at index.android.bundle:1:1839331)
       at ._performTransitionSideEffects(address at index.android.bundle:1:416247)
       at ._receiveSignal(address at index.android.bundle:1:415835)
       at .onResponderRelease(address at index.android.bundle:1:414649)
       at .apply((native):0:0)
       at .invokeGuardedCallbackImpl(address at index.android.bundle:1:337841)
       at .apply((native):0:0)
       at .invokeGuardedCallback(address at index.android.bundle:1:337898)
       at .apply((native):0:0)
       at .invokeGuardedCallbackAndCatchFirstError(address at index.android.bundle:1:337930)
       at .executeDispatch(address at index.android.bundle:1:338062)
       at .executeDispatchesAndReleaseTopLevel(address at index.android.bundle:1:342319)
       at .forEach((native):0:0)
       at .forEachAccumulated(address at index.android.bundle:1:339560)
       at .anonymous(address at index.android.bundle:1:342671)
       at .batchedUpdatesImpl(address at index.android.bundle:1:401877)
       at .batchedUpdates(address at index.android.bundle:1:342239)
       at ._receiveRootNodeIDEvent(address at index.android.bundle:1:342512)
       at .receiveTouches(address at index.android.bundle:1:396657)
       at .apply((native):0:0)
       at .__callFunction(address at index.android.bundle:1:139406)
       at .anonymous(address at index.android.bundle:1:137771)
       at .__guard(address at index.android.bundle:1:138724)
       at .callFunctionReturnFlushedQueue(address at index.android.bundle:1:137729)

aldo-expensify · 2023-06-21T22:17:31Z

I got this on web:

The error looks similar to the one above.

aldo-expensify · 2023-06-21T22:21:46Z

The gmail participants of the group have login: undefined:

I find it strange because these are accounts that existed in my database (I created them before creating the group)

The code crashes around here:

App/src/libs/actions/IOU.js

Line 462 in 1745b01

    
           const formattedParticipants = Localize.arrayToString([currentUserLogin, ..._.map(participants, (participant) => participant.login)]);

These accounts have missing the login in the OpenApp response:

I think that's because I didn't have chats between these accounts before creating the group.

aldo-expensify · 2023-06-21T22:38:08Z

Asking in slack about expected behaviour: https://expensify.slack.com/archives/C03TQ48KC/p1687387011143229

aldo-expensify · 2023-06-21T23:58:12Z

Considering this, this is not a deploy blocker anymore.

aldo-expensify · 2023-06-22T00:21:39Z

I created a draft PR with the progress I was able to make to disallow splitting with accounts that have a missing login. Since less accounts are selected than the total of the group, this ends up creating a sub group with only the selected accounts of the split. See the result in the video here: #21290

I will prioritize other things for now since this is not for SNH anymore.

cc @Beamanator @puneetlath feel free to continue working on this if you want, I won't remove my assignment for now.

aldo-expensify · 2023-06-30T21:15:20Z

@puneetlath @Beamanator I haven't been able to get back to this, and I'm going OOO for the next week. I'll reassign it to @puneetlath since you offered yourself before :)

puneetlath · 2023-07-11T18:23:39Z

I will pick this back up soon.

puneetlath · 2023-09-07T02:46:40Z

Still on hold.

Julesssss · 2023-09-13T08:21:53Z

Reproduced on Android native and iOS native today: 1.3.67-3

puneetlath · 2023-09-18T19:07:30Z

#25714 is getting close.

puneetlath · 2023-10-04T17:08:02Z

Seems to be fixed now!

izarutskaya · 2023-10-10T10:49:59Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

This bug is reproducible again
Creating a Split Bill from a group conversation freezes and an error appears in the console

Expected Result:

Successful Split Bill

Actual Result:

App crashes (Android)
App freezes (Web)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.80.0

Reproducible in staging?: Yes

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.462.1.mp4

Screen.Recording.20231010.135847.One.Ui.Home.mp4

An error appears in production

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

melvin-bot · 2023-10-23T04:45:48Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-10-23T04:45:50Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.88-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Stag] Prevent crash when login is undefined #30102

If no regressions arise, payment will be issued on 2023-10-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

puneetlath · 2023-10-30T15:41:34Z

I don't think anyone needs to be paid here, so closing out.

lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jun 21, 2023

github-actions bot added Engineering Hourly KSv2 labels Jun 21, 2023

OSBotify mentioned this issue Jun 21, 2023

Deploy Checklist: New Expensify 2023-06-21 #21172

Closed

67 tasks

melvin-bot bot assigned aldo-expensify Jun 21, 2023

aldo-expensify added Daily KSv2 Hourly KSv2 and removed Hourly KSv2 DeployBlockerCash This issue or pull request should block deployment labels Jun 21, 2023

aldo-expensify mentioned this issue Jun 22, 2023

Filter out accounts we don't have login yet #21290

Closed

57 tasks

aldo-expensify added Weekly KSv2 and removed Daily KSv2 labels Jun 22, 2023

abekkala mentioned this issue Jun 28, 2023

Web - App crashes when splitting bill with email "—-@—-.com" #21813

Closed

6 tasks

bernhardoj mentioned this issue Jun 30, 2023

split money isn't working on groups #21919

Closed

6 tasks

melvin-bot bot added the Overdue label Jun 30, 2023

melvin-bot bot removed the Overdue label Jun 30, 2023

aldo-expensify assigned puneetlath and unassigned aldo-expensify Jun 30, 2023

melvin-bot bot added the Overdue label Jul 10, 2023

melvin-bot bot removed the Overdue label Sep 7, 2023

melvin-bot bot added the Overdue label Sep 15, 2023

melvin-bot bot removed the Overdue label Sep 18, 2023

melvin-bot bot added the Overdue label Sep 27, 2023

puneetlath closed this as completed Oct 4, 2023

melvin-bot bot removed the Overdue label Oct 4, 2023

izarutskaya reopened this Oct 10, 2023

melvin-bot bot added the Overdue label Oct 18, 2023

luacmartins self-assigned this Oct 20, 2023

melvin-bot bot removed the Overdue label Oct 20, 2023

luacmartins mentioned this issue Oct 20, 2023

[CP Stag] Prevent crash when login is undefined #30102

Merged

59 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 20, 2023

melvin-bot bot changed the title ~~[HOLD #25714] Split bill - App crashes when splitting bill in group with both expensifail and gmail accounts~~ [HOLD for payment 2023-10-30] [HOLD #25714] Split bill - App crashes when splitting bill in group with both expensifail and gmail accounts Oct 23, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Oct 23, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 29, 2023

puneetlath closed this as completed Oct 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-10-30] [HOLD #25714] Split bill - App crashes when splitting bill in group with both expensifail and gmail accounts #21268

[HOLD for payment 2023-10-30] [HOLD #25714] Split bill - App crashes when splitting bill in group with both expensifail and gmail accounts #21268

lanitochka17 commented Jun 21, 2023 •

edited by Julesssss

Loading

OSBotify commented Jun 21, 2023

melvin-bot bot commented Jun 21, 2023

luacmartins commented Jun 21, 2023

aldo-expensify commented Jun 21, 2023

aldo-expensify commented Jun 21, 2023 •

edited

Loading

aldo-expensify commented Jun 21, 2023

aldo-expensify commented Jun 21, 2023

aldo-expensify commented Jun 22, 2023

aldo-expensify commented Jun 30, 2023

puneetlath commented Jul 11, 2023

puneetlath commented Sep 7, 2023

Julesssss commented Sep 13, 2023

puneetlath commented Sep 18, 2023

puneetlath commented Oct 4, 2023

izarutskaya commented Oct 10, 2023 •

edited

Loading

melvin-bot bot commented Oct 23, 2023

melvin-bot bot commented Oct 23, 2023

puneetlath commented Oct 30, 2023

[HOLD for payment 2023-10-30] [HOLD #25714] Split bill - App crashes when splitting bill in group with both expensifail and gmail accounts #21268

[HOLD for payment 2023-10-30] [HOLD #25714] Split bill - App crashes when splitting bill in group with both expensifail and gmail accounts #21268

Comments

lanitochka17 commented Jun 21, 2023 • edited by Julesssss Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

OSBotify commented Jun 21, 2023

melvin-bot bot commented Jun 21, 2023

luacmartins commented Jun 21, 2023

aldo-expensify commented Jun 21, 2023

aldo-expensify commented Jun 21, 2023 • edited Loading

aldo-expensify commented Jun 21, 2023

aldo-expensify commented Jun 21, 2023

aldo-expensify commented Jun 22, 2023

aldo-expensify commented Jun 30, 2023

puneetlath commented Jul 11, 2023

puneetlath commented Sep 7, 2023

Julesssss commented Sep 13, 2023

puneetlath commented Sep 18, 2023

puneetlath commented Oct 4, 2023

izarutskaya commented Oct 10, 2023 • edited Loading

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Oct 23, 2023

melvin-bot bot commented Oct 23, 2023

puneetlath commented Oct 30, 2023

lanitochka17 commented Jun 21, 2023 •

edited by Julesssss

Loading

aldo-expensify commented Jun 21, 2023 •

edited

Loading

izarutskaya commented Oct 10, 2023 •

edited

Loading