[$1000] iOS - 2FA - 2FA displayed enabled after disabling it offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #20738

Action Performed:

Precondition - 2FA is enabled in account

1. Open iOS app
2. Go to Security tab
3. Open 2FA tab
4. Go offline
5. Tap “Disable 2FA”
6. Tap “Disable”
7. Go online
8. Tap “Got it”
9. Tap 2FA again
10. Return back to LHN
11. Proceed back to 2FA tab

Expected Result:

At steps 8 & 10 2FA are displayed disabled

Actual Result:

At step 8 2FA is still displayed enabled
At step 10 2FA is displayed disabled

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.31.3

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

IMG_8216.MP4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0119f93f050052723a
• Upwork Job ID: 1674051567935217664
• Last Price Increase: 2023-06-28

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[abekkala]

@lanitochka17 Can you complete these sections:

Expected Result:

Describe what you think should've happened

Actual Result:

Describe what actually happened

[lanitochka17]

@abekkala Sorry for the confusion. Added information.

[abekkala]

discussing this in slack

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0119f93f050052723a

[melvin-bot]

Current assignee @abekkala is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[Pujan92]

May be dupe of #21568

[abekkala]

@Pujan92 this one was created first so if anything - that other one would be considered the dupe.

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

2FA "Disable Authentication" page comes up again if we navigate back to the page in Offline mode

What is the root cause of that problem?

As we are not blocking the View when the user is offline causing the issue.

What changes do you think we should make in order to solve the problem?

We should wrap the ScrollView with the FullPageOfflineBlockingView component, which will show the offline blocking View to the user and not allow to disabling the 2FA in offline mode.

App/src/pages/settings/Security/TwoFactorAuth/IsEnabledPage.js

Line 26 in 9604ac7

<ScrollView>

Result

Screen.Recording.2023-06-27.at.7.10.38.PM.mov

#21568 (comment)

[thesahindia]

Let's close this. @0xmiroslav has already reviewed the proposal at #21568