[HOLD for payment 2024-01-24] [$1000] Chat - User experienced big delay when posting the messages

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with own account
3. Open a public room https://staging.new.expensify.com/r/5593084223054221
4. Send messages

Expected Result:

Messages arrived on time

Actual Result:

User experienced big delay when posting the messages

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.29.0

Reproducible in staging?: y

Reproducible in production?: y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: David Barrett

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686956800520439

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c5aa8e942309dcf4
• Upwork Job ID: 1673361704564097024
• Last Price Increase: 2023-06-26

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[quinthar]

This is pretty easily solved by just measuring the "skew" between the client and server clocks:

startTime = NOW();
response = send(GetCurrentTime);
endTime = NOW();
latency = (endTime - startTime)/2;
skew = response.serverTime - startTime + latency;

Then whenever we generate a client-side timestamp, we just add the skew and it will be a much closer approximation of what the server time is at that exact moment.

[quinthar]

Lots more detail on that Slack thread.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c5aa8e942309dcf4

[melvin-bot]

Current assignee @lschurr is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[lschurr]

Not overdue. Just reviewed and added External.

[lschurr]

Waiting on proposals.

[Piotrfj]

Hi I'm Piotr from Callstack - expert contributor group - will start investigation in this area

[melvin-bot]

📣 @Piotrfj! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

📣 @Santhosh-Sellavel You have been assigned to this job!
Please apply to this job in Upwork here and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

The BZ member will need to manually hire Piotrfj for this role Contributor. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

[lschurr]

Thanks @Piotrfj - have you had a chance to work on this yet?

[Piotrfj]

Current experience of writing a message in desktop version:

Kapture.2023-07-04.at.14.30.54.mp4

There is visible delay between clicking send icon (or pressing enter), but it is so small it makes me wonder if this is the the thing the issue is about.

If the issue is truly about that I think we could change the behavior in a way where the message is appearing instantly on the chat history and it will not wait for the response (because thats my guess of what is happening in this case).

Please provide me some clarification about that.

[melvin-bot]

This issue has not been updated in over 15 days. @nkuoch, @lschurr, @waterim, @situchan eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[lschurr]

What's the latest on this one @situchan @waterim?

[situchan]

Latest update: waiting for @waterim to address last feedback after back from OOO

[waterim]

This one was merged!
Hopefully no regression will appear

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.25-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Reopened/Fix: User experienced big delay when posting the messages #30605

If no regressions arise, payment will be issued on 2024-01-24. 🎊

For reference, here are some details about the assignees on this issue:

• @waterim does not require payment (Contractor)
• @situchan requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[lschurr]

Looks like this didn't automatically move to Daily.

@situchan - Can you work through the checklist on this one?

[lschurr]

Payment summary:

• Bug report: Internal (no payment)
• Contributor: @waterim (contracted - no payment)
• Contributor+: @situchan $500 (Upwork offer)

[situchan]

BZ Checklist:
No PR caused regression.
This is edge case and I don't think we need regression test.

[situchan]

This is very old issue and can we keep original base price?

[situchan]

I am not eligible yet for newdot payment. still using upwork

[lschurr]

This is very old issue and can we keep original base price?

There was a regression #28673 which decreases the payment to $500. I'll create a new job in Upwork and invite you.

[lschurr]

Upwork offer here: https://www.upwork.com/nx/wm/offer/100623865

[situchan]

yes, there was regression but it couldn't have been caught during PR review. Both author and reviewer were not able to reproduce.
2nd PR was also QA'ed by 3rd party since again we're not able to reproduce.
We tried our best to find any regressions but unfortunately not.
And no other contributors were involved, so no overpayment for this issue.

Similar case: #30042 (comment)

cc: @mountiny

[lschurr]

Thanks @situchan - we discussed in Slack and decided to keep the payment at $1000. I'll modify in Upwork.

[situchan]

Thanks so much

[lschurr]

New offer sent - can you accept in Upwork @situchan

[lschurr]

Great, payment sent in Upwork. We're all set.