Dev - Web - Two console error when open user url

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to android
2. Create a new workspace
3. Click on FAB icon and click on new room
4. Enter the room name
5. On workspace, select the newly created workspace from the dropdown and notice that even when we have selected the workspace, it throws an error 'Please select a workspace'
6. If you again select a new workspace from the dropdown, this time no error will be shown

Expected Result:

No console error.

Actual Result:

There is two console error.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.32-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-22.at.12.20.37.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @ahmedGaber93
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687430016132759

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Proposal

From: @ahmedGaber93

Please re-state the problem that we are trying to solve in this issue.

Dev - web - two console error when open user url.

Warning: Failed prop type: Invalid prop `style` of type `object` supplied to `PressableWithoutFocus`, expected an array.
Warning: Failed prop type: Provide a valid string for accessibilityLabel prop when accessible is true at GenericPressable

What is the root cause of that problem?

error 1: prop style passed as object while it defined in propTypes as array.

App/src/pages/DetailsPage.js

Lines 150 to 153 in 9bef507

	<PressableWithoutFocus
	style={styles.noOutline}
	onPress={show}
	>

error2: GenericPressable has default prop accessible: true without having accessibilityLabel prop

App/src/components/Pressable/GenericPressable/PropTypes.js

Line 136 in 9bef507

accessible: true,

What changes do you think we should make in order to solve the problem?

error1: edit style prop to be array or change prop type to accept object

// style={styles.noOutline}
style={[styles.noOutline]}
// or
// style: PropTypes.arrayOf(PropTypes.object)
style: PropTypes.oneOfType([PropTypes.arrayOf(PropTypes.object), PropTypes.object])

error2: add prop accessibilityLabel to PressableWithoutFocus and pass it to GenericPressable

What alternative solutions did you explore? (Optional)

error2: remove default prop accessible: true from GenericPressable.

[dhairyasenjaliya]

@laurenreidexpensify this issue is a dupe of #21556

[ahmedGaber93]

@dhairyasenjaliya This issue has 2 console error, one is a dupe as you mentioned, but the other is not.
Thanks!

[dhairyasenjaliya]

@ahmedGaber93 the other error is also dupped of #21506 I have added proposal to solve both #21506 (comment)