Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-06-28 #21794

Closed
26 tasks done
OSBotify opened this issue Jun 28, 2023 · 9 comments
Closed
26 tasks done

Deploy Checklist: New Expensify 2023-06-28 #21794

OSBotify opened this issue Jun 28, 2023 · 9 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Jun 28, 2023

Release Version: 1.3.34-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jun 28, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.34-1 🚀

@francoisl
Copy link
Contributor

Tested 20194 internally because it required a Gold wallet and deposit account set up, checking it.

@arosiclair
Copy link
Contributor

#21257 passes

@thienlnam
Copy link
Contributor

thienlnam commented Jun 28, 2023

Looks like @Julesssss is OOO, but this seems to be able to be tested by QA. Do testers have a staging Android build installed to test this?

#19613

EDIT: Asked here https://expensify.slack.com/archives/C9YU7BX5M/p1687989260174849

@Julesssss
Copy link
Contributor

I'm back in today and checked off #19613

@mvtglobally
Copy link

@thienlnam Regression is completed.

PR #21241 has issue #21827 but seem repro in PROD.

@thienlnam
Copy link
Contributor

Lovely - thank you all!

@thienlnam
Copy link
Contributor

Screenshot 2023-06-29 at 10 08 22 AM

Incident with actions so holding off on deploy

@thienlnam
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

7 participants