Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-07-12] Lounge Access Status is not loaded when accessing profile directly #21830

Closed
3 of 6 tasks
yuwenmemon opened this issue Jun 28, 2023 · 9 comments
Closed
3 of 6 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@yuwenmemon
Copy link
Contributor

yuwenmemon commented Jun 28, 2023

Action Performed:

  1. Be on an account that has lounge access (AKA is paying for a subscription or is part of a current paid policy)
  2. Log out of new.expensify.com if you are not logged out already
  3. Go to https://new.expensify.com/settings/profile directly in the browser by pasting into the URL
  4. Sign in

Expected Result:

  1. The Lounge Access Menu item should appear in your profile without needing to go back and forth.

Actual Result:

  1. Lounge Access Badge does not appear in your profile (It will show up after clicking the back button and clicking the 'Profile' menu item again)

Workaround:

  1. The badge will show up after clicking the back button and then clicking the 'Profile' menu item again)

Platforms:

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01beea7f042ec2da2d
  • Upwork Job ID: 1674111576481267712
  • Last Price Increase: 2023-06-28
@yuwenmemon yuwenmemon added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 28, 2023
@yuwenmemon yuwenmemon self-assigned this Jun 28, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 28, 2023

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot

This comment was marked as resolved.

@yuwenmemon
Copy link
Contributor Author

Will work on this internally since this is my bug originally. Although it's reasonably a front-end issue.

@yuwenmemon yuwenmemon added the Internal Requires API changes or must be handled by Expensify staff label Jun 28, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 28, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01beea7f042ec2da2d

@melvin-bot
Copy link

melvin-bot bot commented Jun 28, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @narefyev91 (Internal)

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jun 28, 2023
@melvin-bot melvin-bot bot changed the title Lounge Access Status is not loaded when accessing profile directly [HOLD for payment 2023-07-12] Lounge Access Status is not loaded when accessing profile directly Jul 5, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 5, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jul 5, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.36-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-07-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot
Copy link

melvin-bot bot commented Jul 5, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@narefyev91] The PR that introduced the bug has been identified. Link to the PR:
  • [@narefyev91] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@narefyev91] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@narefyev91] Determine if we should create a regression test for this bug.
  • [@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jul 11, 2023
@yuwenmemon
Copy link
Contributor Author

@bfitzexpensify can we pay out @narefyev91 and close this out?

@melvin-bot melvin-bot bot removed the Overdue label Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

3 participants