mWeb - Long press on X for message edit suppresses keyboard instead of cancelling editing

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #21764

Action Performed:

1. Login to NewDot on mWeb
2. Open any chat
3. Tap to edit any message
4. Long press on X to close edit window

Expected Result:

Edit box closed

Actual Result:

Suppressed keyboard instead of cancelling editing

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.35.4

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6112171_video_16.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[s-alves10]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Long press on X button in message edit suppresses keyboard instead of cancelling edit

What is the root cause of that problem?

As you can see below, we added only onPress handler to the Pressable

App/src/pages/home/report/ReportActionItemMessageEdit.js

Line 259 in 5a713dd

onPress={deleteDraft}

On long-press, onPress isn't called as you can see here

This is the root cause

What changes do you think we should make in order to solve the problem?

I'm not sure if this is a bug.
If this is not an expected behavior, we can add onLongPress or onPressOut handler to the Pressabe

This works as expected.

Result

21966.mp4

What alternative solutions did you explore? (Optional)

[melvin-bot]

@puneetlath Whoops! This issue is 2 days overdue. Let's get this updated quick!

[puneetlath]

I don't think this is a bug because I don't think the user has any expectation of what long press will do in this scenario. Tapping the x button works, which is what the user would expect. I'm going to close, but feel free to comment here if you disagree!