Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkmark appears in incorrect position for paid IOU thread #22021

Closed
6 tasks done
kavimuru opened this issue Jul 1, 2023 · 13 comments
Closed
6 tasks done

Checkmark appears in incorrect position for paid IOU thread #22021

kavimuru opened this issue Jul 1, 2023 · 13 comments
Assignees

Comments

@kavimuru
Copy link

kavimuru commented Jul 1, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Request money from user A to user B
  2. From user B settle that amount
  3. Open the IOU thread
  4. Click on the IOU paid card

Expected Result:

Green checkmark should be beside the amont

Actual Result:

Appears at the right end

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.3.35-5
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
WhatsApp Image 2023-07-01 at 2 20 49 PM
WhatsApp Image 2023-07-01 at 2 18 33 PM
1

Expensify/Expensify Issue URL:
Issue reported by: @manjesh-yadav
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688099500775589

View all open jobs on GitHub

@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 1, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 1, 2023

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jul 1, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

OSBotify commented Jul 1, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jul 1, 2023

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kushu7
Copy link
Contributor

kushu7 commented Jul 2, 2023

Its regression from https://github.com/Expensify/App/pull/21769/files
flex1 was added in this PR.

@sophiepintoraetz
Copy link
Contributor

I'm able to reproduce this! Will stay assigned so I can pay out the reporting bonus
image

@sophiepintoraetz
Copy link
Contributor

cc @dukenv0307 @cristipaval @mananjadhav - seeing as you were involved with the PR regression (thank you @kushu7!)

@mananjadhav
Copy link
Collaborator

@sophiepintoraetz I think this was fixed #21936 but not deployed to staging.

@cristipaval
Copy link
Contributor

yes, it was fixed but not deployed yet in the PR linked above. Also, we can safely remove the deploy blocker label since it is a styling issue that does not block the user at all.

@cristipaval cristipaval removed the DeployBlockerCash This issue or pull request should block deployment label Jul 3, 2023
@sophiepintoraetz sophiepintoraetz added Daily KSv2 and removed Hourly KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 3, 2023
@sophiepintoraetz
Copy link
Contributor

Yup - fixed
image

@manjesh-yadav
Copy link
Contributor

I'm able to reproduce this! Will stay assigned so I can pay out the reporting bonus image

As this issue is closed I should be compensated for reporting bonus @sophiepintoraetz

@sophiepintoraetz
Copy link
Contributor

offer sent @manjesh-yadav

@manjesh-yadav
Copy link
Contributor

Offer accepted @sophiepintoraetz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants