[$1000] Web - Owed information is wrong when sending money request between accounts

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to account A and Account B on different devices
2. From account A: send Money request to account B, with "amount = X"
3. From account B: send Money request to account A, with SAME "amount = X
"
   Observer that: these 2 request will be marked as paid automatically
4. From account B: send ANOTHER money request to A, with "amount = Y"
5. Check the request information

Expected Result:

The request information should say “A owes Y”

• The “Pay elsewhere button” is displayed on account A

Actual Result:

The request information shows “B owes Y”

• The “Pay elsewhere button” is displayed on account B

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.35-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Wrong-Owe-information.mp4

Recording.3397.2.mp4

Expensify/Expensify Issue URL:
Issue reported by: ToanSel
QA Engineer - Github: @tranvantoan-qn
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688446357913299

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e1a2f08520a2ebd5
• Upwork Job ID: 1678605892035735552
• Last Price Increase: 2023-08-01

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jeet-dhandha]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• The text ${payer} owes ${amount} is confusing when looking from the requestor's perspective.

What is the root cause of that problem?

• The text is confusing because it is written from the perspective of the payer, not the requestor.

What changes do you think we should make in order to solve the problem?

• The text should be written from the perspective of the requestor. Like You owe ${amount}.
• For the payer, the text should be same ${payer} owes ${amount}.

What alternative solutions did you explore? (Optional)

• N/A

[melvin-bot]

@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mallenexpensify]

Was able to reproduce, thinking/hoping this can be External

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e1a2f08520a2ebd5

[melvin-bot]

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Owed information is wrong

What is the root cause of that problem?

The real problem is bigger than the mentioned one.

• When User A requests money, the IOU information will be "User A owes money."
• When User B requests money, the IOU information will be the same, "User A owes money" (regardless of whether User B's requested amount is larger than User A's).
• The app will continue adding data to the same IOU report until the "PAY elsewhere" button is pressed or the user settles the amount.

In this case, the app should display a separate IOU report, or it should calculate the previous amounts to determine who owes the most money.

What changes do you think we should make in order to solve the problem?

My first suggestion would be this

• the app should display a separate IOU report when different user requests the money
• or it should calculate the previous amounts to determine who owes the most money.

What alternative solutions did you explore? (Optional)

[StevenKKC]

I am unable to reproduce the issue on latest dev. This PR seems to have already fixed the issue.

[mallenexpensify]

Also unable to reproduce so closing, amount owed is now showing correctly. comment if you disagree

[tranvantoan-qn]

@mallenexpensify
I tried to verify it on main, but it seems like when A sends a request money to B, the amount with be paid automatically.?
(so I couldn't perform the same set of steps to reproduce it)

auto-paid.mov

[tranvantoan-qn]

@mallenexpensify
Clear cache helps fix the "auto-paid" issue above, but the issue is still happening after step 4 as mentioned in Action Performed.

Please check the attached image - in which I added a details explanation:

• From account B:
  • It shows "Account A owes đ6000" - which is CORRECT
  • Pay elsewhere button is displayed >> INCORRECT, it should be displayed on Account A
• From account A:
  • It shows Account B owes đ6000 - which is INCORRECT

still.happening.mov

Please let me know if I can help to reproduce it

[tranvantoan-qn]

@mallenexpensify
Hope that you can consider 2 things:

• The issue doesn't seem to be completely fixed as it's still occurring.
• Am I eligible for a reporting bonus? My report was valid and initially had no connection with this PR

Thank you!

[mallenexpensify]

@tranvantoan-qn I tried to repro again a couple times between two accounts, back and forth, with no luck.
For the bug reporting bonus, since @kbecciv was able to reproduce, it appears it was a valid bug. I looked around to try to find the PR that fixed it, d you know @tranvantoan-qn or @aimane-chnaif ?

[mallenexpensify]

Checking in Slack https://expensify.slack.com/archives/C049HHMV9SM/p1689627262480169?thread_ts=1688446357.913299&cid=C049HHMV9SM

I'd like to know what PR fixed this before deciding on potential payment for the reporting bonus.

[tranvantoan-qn]

Yes, I understand @mallenexpensify
But I've seen some exceptions when everyone initially agrees that the bug report is Valid
#21158
#21996

So I hope my case be considered too

[melvin-bot]

@mallenexpensify, @aimane-chnaif Eep! 4 days overdue now. Issues have feelings too...

[mallenexpensify]

@tranvantoan-qn can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01ac3ffaa7bc12de84

You reported a valid bug that was reproducible and now it's not, and no one can identify where/how it was fixed, I asked for help/ 👀 multiple times too.

[tranvantoan-qn]

@mallenexpensify
Thank you! I've accepted the offer

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@mallenexpensify @aimane-chnaif this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

Current assignee @aimane-chnaif is eligible for the Internal assigner, not assigning anyone new.

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

@mallenexpensify, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@mallenexpensify, @aimane-chnaif 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@mallenexpensify, @aimane-chnaif 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[aimane-chnaif]

Not overdue

[melvin-bot]

@mallenexpensify, @aimane-chnaif Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@mallenexpensify, @aimane-chnaif 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@mallenexpensify, @aimane-chnaif 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[mallenexpensify]

@mvtglobally can you do one more test to see if this is reproducible? If not, can you please close? Thx

[melvin-bot]

@mallenexpensify, @aimane-chnaif Eep! 4 days overdue now. Issues have feelings too...

[mallenexpensify]

Issue reporter: @tranvantoan-qn paid $250 via Upwork

Closing, as mentioned above, this was a valid bug when it was reported and we were unable to determine what fixed it, so compensation was due