Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: Expensify.cash 2021-04-09 #2332

Closed
8 tasks done
OSBotify opened this issue Apr 9, 2021 · 4 comments
Closed
8 tasks done

Deploy Checklist: Expensify.cash 2021-04-09 #2332

OSBotify opened this issue Apr 9, 2021 · 4 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@isagoico isagoico added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Apr 12, 2021
@isagoico
Copy link

Regression is finished!
No issues found today.

PRs are finished too!
1 comment added:

  1. Refactor picker to be a cross-platform component #2242 (comment)

Thanks!
CC @roryabraham

@roryabraham
Copy link
Contributor

roryabraham commented Apr 12, 2021

It looks like #2242 (comment) was not QA-able due to unrelated reasons, so we're going to give @tgolen the benefit of the doubt and assume that the PR is a pass so that we can run a production deploy.

@OSBotify OSBotify reopened this Apr 12, 2021
@OSBotify
Copy link
Contributor Author

This issue either has unchecked QA steps or has not yet been marked with the :shipit: emoji of approval.
Reopening!

@roryabraham
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

4 participants