Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD https://github.com/Expensify/App/pull/20821] [$1000] DEV: Requesting money after getting paid in a workspace stops working #23334

Closed
1 of 6 tasks
kavimuru opened this issue Jul 21, 2023 · 13 comments
Closed
1 of 6 tasks

[HOLD https://github.com/Expensify/App/pull/20821] [$1000] DEV: Requesting money after getting paid in a workspace stops working #23334

kavimuru opened this issue Jul 21, 2023 · 13 comments
Assignees
@jliexpensify @Santhosh-Sellavel
Labels
Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Jul 21, 2023 •
edited by melvin-bot bot
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Create 2 accounts. In the video, 6050@expensifail.com is the workspace owner and 6051@expensifail.com is an invited member
  2. 6051@expensifail.com requests money in their workspace chat
  3. 6050@expensifail.com adds a VBBA and pays the money requests
  4. 6051@expensifail.com tries to request money again

Expected result:

The money request should work and a new expense report should be created

Actual result:

The money request amount is added to the previous expense report that is already payed. The backend threw an error and no error is reported in the UI.

it shows a second bug where 6051@expensifail.com can't create a DM chat with 6050@expensifail.com anymore. The search shows only the last expense report and the workspace chat, but it is not possible to create a DM chat outside of the existing workspaces chats

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: dev
Reproducible in staging?: dev
Reproducible in production?: dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-19.at.11.25.56.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @aldo-expensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689791415511559

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d897bad012991ac0
  • Upwork Job ID: 1682243955987083264
  • Last Price Increase: 2023-07-21
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 21, 2023

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jul 21, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@kavimuru kavimuru added the Needs Reproduction Reproducible steps needed label Jul 21, 2023
@jliexpensify
Copy link
Contributor

Aldo reported this so it'll be reproducible.

@jliexpensify jliexpensify added External Added to denote the issue can be worked on by a contributor and removed Needs Reproduction Reproducible steps needed labels Jul 21, 2023
@melvin-bot melvin-bot bot changed the title DEV: Requesting money after getting paid in a workspace stops working [$1000] DEV: Requesting money after getting paid in a workspace stops working Jul 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 21, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01d897bad012991ac0

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 21, 2023

Current assignee @jliexpensify is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Jul 21, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

@sjoseph92
Copy link

Is there a way to test pay without adding a bank account?

@aldo-expensify
Copy link
Contributor

aldo-expensify commented Jul 21, 2023 •
edited
Loading

Heads up, I was told that there is a PR being worked on that will fix it. I don't have the link of the PR yet, but I'll remove Help Wanted and putting on HOLD for now.

Update: this PR #20821

@aldo-expensify aldo-expensify removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 21, 2023
@aldo-expensify aldo-expensify changed the title [$1000] DEV: Requesting money after getting paid in a workspace stops working [HOLD] [$1000] DEV: Requesting money after getting paid in a workspace stops working Jul 21, 2023
@aldo-expensify aldo-expensify removed the External Added to denote the issue can be worked on by a contributor label Jul 21, 2023
@aldo-expensify aldo-expensify changed the title [HOLD] [$1000] DEV: Requesting money after getting paid in a workspace stops working [HOLD https://github.com/Expensify/App/pull/20821] [$1000] DEV: Requesting money after getting paid in a workspace stops working Jul 21, 2023
@aldo-expensify aldo-expensify added Weekly KSv2 and removed Daily KSv2 labels Jul 21, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 31, 2023
@jliexpensify
Copy link
Contributor

On HOLD

@melvin-bot melvin-bot bot removed the Overdue label Aug 3, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 11, 2023
@jliexpensify
Copy link
Contributor

On hold

@melvin-bot melvin-bot bot removed the Overdue label Aug 14, 2023
@Santhosh-Sellavel
Copy link
Collaborator

@aldo-expensify @jliexpensify Seems this PR #20821 is merged, can you confirm whether this is reproducible for you if not we can close this!

@jliexpensify
Copy link
Contributor

@aldo-expensify is this in DEV only? If so, could you test this one?

@aldo-expensify
Copy link
Contributor

Can't reproduce anymore, it works 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jliexpensify jliexpensify

@Santhosh-Sellavel Santhosh-Sellavel

Labels
Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jliexpensify @kavimuru @sjoseph92 @Santhosh-Sellavel @aldo-expensify