[$1000] Web - Historical IOUs appearing in LHN like a pinned chat, above more recent chats, though they aren’t pinned #23438

kbecciv · 2023-07-23T19:18:01Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open the app
If you have any old historical reports, then these will appear immediately below your pinned chats and above chat with more recent activity
Tap into the IOU report. The right header is also missing

Expected Result:

Old IOUs shouldn’t appear above more recent chats, all IOUs should also have modern headers that links back to the parent report to which they are attached.

Actual Result:

Again, the headers are incorrect, the chats are being sorted incorrectly in the LHN vs more recent chats

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.43-7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689959205989049

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0113e10683f580c981
Upwork Job ID: 1683416987148619776
Last Price Increase: 2023-07-31
Automatic offers:

WikusKriek | Contributor | 26116737

melvin-bot · 2023-07-23T19:18:05Z

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-07-23T19:18:07Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-07-24T10:01:02Z

Job added to Upwork: https://www.upwork.com/jobs/~0113e10683f580c981

melvin-bot · 2023-07-24T10:01:06Z

Current assignee @dylanexpensify is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-07-24T10:01:11Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (External)

AbeDev404 · 2023-07-24T10:31:48Z

Contributor details
Your Expensify account email: Beautifulworld820.1@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0167895ac603e3df53

melvin-bot · 2023-07-24T10:31:50Z

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

phamnduy · 2023-07-24T14:37:24Z

Contributor details
Your Expensify account email: phamngocduy96@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~016a77b711407d33f1

melvin-bot · 2023-07-24T14:37:27Z

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

mhd-sln · 2023-07-24T17:02:22Z

Contributor details
Your Expensify account email: salmanmanekia@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~013fd6c7567d64dfa6

melvin-bot · 2023-07-24T17:02:23Z

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

mhd-sln · 2023-07-24T17:10:32Z

Contributor details
Your Expensify account email: salmanmanekia@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~013fd6c7567d64dfa6

melvin-bot · 2023-07-24T17:10:34Z

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

JmillsExpensify · 2023-07-24T21:38:43Z

This is still happening to me. I had even more appear today.

ArekChr · 2023-07-25T09:32:49Z

Waiting for proposals 📣

priyankrawat · 2023-07-26T05:18:01Z

Contributor details
Your Expensify account email: rawat.priyank@yahoo.in
Upwork Profile Link: https://www.upwork.com/freelancers/~01dea109e55d7750c6

melvin-bot · 2023-07-26T05:18:04Z

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

WikusKriek · 2023-07-26T19:38:58Z

This is still happening to me. I had even more appear today.

I am trying to understand exactly what is happening here.

Where you perhaps waiting on a credit bank account?

App/src/libs/ReportUtils.js

Lines 1071 to 1095 in 5ffd4e6

    
           function isWaitingForIOUActionFromCurrentUser(report, allReportsDict = null) { 
        
               const allAvailableReports = allReportsDict || allReports; 
        
               if (!report || !allAvailableReports) { 
        
                   return false; 
        
               } 
        
               // Money request waiting for current user to add their credit bank account 
        
               if (report.ownerAccountID === currentUserAccountID && report.isWaitingOnBankAccount) { 
        
                   return true; 
        
               } 
        
               let reportToLook = report; 
        
               if (report.iouReportID) { 
        
                   const iouReport = allAvailableReports[`${ONYXKEYS.COLLECTION.REPORT}${report.iouReportID}`]; 
        
                   if (iouReport) { 
        
                       reportToLook = iouReport; 
        
                   } 
        
               } 
        
               // Money request waiting for current user to Pay (from chat or from iou report) 
        
               if (reportToLook.ownerAccountID && (reportToLook.ownerAccountID !== currentUserAccountID || currentUserAccountID === reportToLook.managerID) && reportToLook.hasOutstandingIOU) { 
        
                   return true; 
        
               } 
        
               return false; 
        
           }

problem seems to be here in this function, either in the report.isWaitingOnBankAccount is true, or reportToLook.hasOutstandingIOU is not changed.

dylanexpensify · 2023-07-28T09:59:59Z

@ArekChr mind giving @WikusKriek a reply?

dylanexpensify · 2023-07-31T09:09:00Z

bump @ArekChr!

tgolen · 2023-08-14T17:16:52Z

OK, thanks for clarifying. I'm OK with this proposal now and request that the PR also:

Updates the comment about the groups and the sorting
Removes the unnecessary unit test for the pending bank account

melvin-bot · 2023-08-14T17:17:03Z

📣 @mananjadhav Please request via NewDot manual requests for the Reviewer role ($1000)

melvin-bot · 2023-08-14T17:17:08Z

📣 @WikusKriek 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

WikusKriek · 2023-08-15T13:38:11Z

Starting on the PR now.

melvin-bot · 2023-08-17T20:06:06Z

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

when @WikusKriek got assigned: 2023-08-14 17:17:08 Z
when the PR got merged: 2023-08-17 20:06:05 UTC
days elapsed: 3

On to the next one 🚀

mananjadhav · 2023-08-18T16:35:35Z

We got delayed by a few hours, I would request if we can still apply the bonus here. The QA was done, I spent quite a lot of time on getting my builds for Android and iOS.

dylanexpensify · 2023-08-18T19:14:01Z

CC @tgolen thoughts? Seems understandable to me

dylanexpensify · 2023-08-21T10:16:06Z

After discussing internally, we'll be sticking with the standard timeline requirement. For context, this stemmed from discussing grace periods and the outcomes where the boundaries we establish become fuzzy and ultimately hinder the initial premise behind offering this. Thanks for your understanding <3

dylanexpensify · 2023-08-21T10:58:52Z

Payment summary:

Contributor: @WikusKriek $1,000
Contributor+: @mananjadhav $1,000

Upwork job. Please apply!

mananjadhav · 2023-08-22T13:56:13Z

Thanks for the clarification. Totally agreed.

dylanexpensify · 2023-08-25T11:47:21Z

Waiting for regression period to be over!

mananjadhav · 2023-08-31T14:31:32Z

@dylanexpensify Can you please post the payment summary here? This has been in production for 7 days, but the title isn't updated.

mananjadhav · 2023-09-03T20:11:54Z

I couldn't pinpoint to a specific PR here, as the logic has existed since long.

I also don't think we need to add a regression test here.

mananjadhav · 2023-09-04T16:21:46Z

@dylanexpensify Quick bump on this one.

mananjadhav · 2023-09-07T18:47:23Z

@JmillsExpensify a quick follow up on the payout here.

JmillsExpensify · 2023-09-10T11:11:54Z

$1,000 approved for payment based on BZ summary.

WikusKriek · 2023-09-12T05:21:36Z

@dylanexpensify can you please update the title of the issue I think the automation failed here. And this should have been payed 2 weeks ago.

mananjadhav · 2023-09-17T16:51:50Z

@dylanexpensify Can we please payout @WikusKriek? If already done, can we close this one out?

and I changed my mind about adding regression tests.

Regression Test Steps

Open the app
Verify that the LHN are ordered in the order of the list
- Pinned
- Outstanding IOUs
- Drafts
- Non-archived reports and settled IOUs
- Archived reports

WikusKriek · 2023-09-20T08:35:05Z

I have not recieved payment yet, is @dylanexpensify maybe OOO? The last time he was active here was almost one month ago. Can we maybe get someone to just do the payment and close this one out?

dylanexpensify · 2023-09-20T08:44:57Z

Ah let me get it to you now @WikusKriek! Apologies I was ooo!

dylanexpensify · 2023-09-20T08:45:50Z

done!

WikusKriek · 2023-09-20T08:57:51Z

done!

Thanks!

kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 23, 2023

melvin-bot bot assigned dylanexpensify Jul 23, 2023

dylanexpensify added the External Added to denote the issue can be worked on by a contributor label Jul 24, 2023

melvin-bot bot changed the title ~~Web - Historical IOUs appearing in LHN like a pinned chat, above more recent chats, though they aren’t pinned~~ [$1000] Web - Historical IOUs appearing in LHN like a pinned chat, above more recent chats, though they aren’t pinned Jul 24, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 24, 2023

melvin-bot bot assigned ArekChr Jul 24, 2023

melvin-bot bot added the Overdue label Jul 27, 2023

melvin-bot bot added Overdue and removed Overdue labels Jul 28, 2023

tgolen assigned WikusKriek Aug 14, 2023

WikusKriek mentioned this issue Aug 15, 2023

23438 historical IOUs appearing in LHN under pinned chats #24586

Merged

58 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 Weekly KSv2 labels Aug 15, 2023

dylanexpensify closed this as completed Sep 20, 2023

[$1000] Web - Historical IOUs appearing in LHN like a pinned chat, above more recent chats, though they aren’t pinned #23438

[$1000] Web - Historical IOUs appearing in LHN like a pinned chat, above more recent chats, though they aren’t pinned #23438

Comments

kbecciv commented Jul 23, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Jul 23, 2023

melvin-bot bot commented Jul 23, 2023 • edited by dylanexpensify Loading

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Jul 24, 2023

melvin-bot bot commented Jul 24, 2023

melvin-bot bot commented Jul 24, 2023

AbeDev404 commented Jul 24, 2023

melvin-bot bot commented Jul 24, 2023

phamnduy commented Jul 24, 2023

melvin-bot bot commented Jul 24, 2023

mhd-sln commented Jul 24, 2023 • edited Loading

melvin-bot bot commented Jul 24, 2023

mhd-sln commented Jul 24, 2023

melvin-bot bot commented Jul 24, 2023

JmillsExpensify commented Jul 24, 2023

ArekChr commented Jul 25, 2023 • edited Loading

priyankrawat commented Jul 26, 2023

melvin-bot bot commented Jul 26, 2023

WikusKriek commented Jul 26, 2023 • edited Loading

dylanexpensify commented Jul 28, 2023

dylanexpensify commented Jul 31, 2023

tgolen commented Aug 14, 2023

melvin-bot bot commented Aug 14, 2023

melvin-bot bot commented Aug 14, 2023

WikusKriek commented Aug 15, 2023

melvin-bot bot commented Aug 17, 2023

mananjadhav commented Aug 18, 2023

dylanexpensify commented Aug 18, 2023

dylanexpensify commented Aug 21, 2023

dylanexpensify commented Aug 21, 2023

mananjadhav commented Aug 22, 2023

dylanexpensify commented Aug 25, 2023

mananjadhav commented Aug 31, 2023

mananjadhav commented Sep 3, 2023

mananjadhav commented Sep 4, 2023

mananjadhav commented Sep 7, 2023

JmillsExpensify commented Sep 10, 2023

WikusKriek commented Sep 12, 2023

mananjadhav commented Sep 17, 2023

WikusKriek commented Sep 20, 2023 • edited Loading

dylanexpensify commented Sep 20, 2023

dylanexpensify commented Sep 20, 2023

WikusKriek commented Sep 20, 2023

kbecciv commented Jul 23, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jul 23, 2023 •

edited by dylanexpensify

Loading

mhd-sln commented Jul 24, 2023 •

edited

Loading

ArekChr commented Jul 25, 2023 •

edited

Loading

WikusKriek commented Jul 26, 2023 •

edited

Loading

WikusKriek commented Sep 20, 2023 •

edited

Loading