-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-08-21] Update App to react-native version 0.72.3 and remove patches #24208
Comments
Triggered auto assignment to @anmurali ( |
Triggered auto assignment to Design team member for new feature review - @shawnborton ( |
Sorry shawn, no design change is required here. |
Hi, I'm Fábio from Callstack - expert contributor group - and I would like to take a look at this issue. |
PR is ready: #24224 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-08-21. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
HOLD on payment |
Bumping to weekly. cc @anmurali we need to issue payment here |
Offer is here @aimane-chnaif |
@aimane-chnaif are you paid. If so, I think we can close this now |
Contract accepted. Still awaiting approval |
@anmurali could you please help here to accept the contract |
Waiting for approval from @anmurali |
Same ^ cc @anmurali |
I just checked history. Received payment on Oct 3. |
Thanks for confirming! |
Coming from this discussion in slack https://expensify.slack.com/archives/C01GTK53T8Q/p1691377395570339
We upgraded to react-native
0.72.1
. There were still some breaking issues and we applied patch for that. Example: #24203Update react-native to
0.72.3
(latest as of today) and remove the patchesIssue Owner
Current Issue Owner: @anmuraliThe text was updated successfully, but these errors were encountered: