Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-11-30] [TS migration] Migrate 'PushNotification.js' lib to TypeScript #24862

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Task Typescript Migration Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/libs/actions/PushNotification.js 4
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@kowczarz
Copy link
Contributor

Hey! I’m Kamil Owczarz from Software Mansion, an expert agency, and I’d like to work on this issue!

@kowczarz
Copy link
Contributor

Blocked by #24877

@kowczarz
Copy link
Contributor

Unblocked, I will work on it next week.

Copy link
Author

melvin-bot bot commented Nov 18, 2023

Triggered auto assignment to @blimpich, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 23, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'PushNotification.js' lib to TypeScript [HOLD for payment 2023-11-30] [TS migration] Migrate 'PushNotification.js' lib to TypeScript Nov 23, 2023
Copy link
Author

melvin-bot bot commented Nov 23, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 23, 2023
Copy link
Author

melvin-bot bot commented Nov 23, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.2-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Nov 30, 2023
@blimpich blimpich added the NewFeature Something to build that is a new item. label Dec 4, 2023
Copy link
Author

melvin-bot bot commented Dec 4, 2023

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Overdue Daily KSv2 labels Dec 4, 2023
@blimpich
Copy link
Contributor

blimpich commented Dec 4, 2023

@slafortune added new feature label to handle paying the C+ who reviewed the associated PR. See this slack thread for context: https://expensify.slack.com/archives/C03TQ48KC/p1701718644763699

@slafortune
Copy link
Contributor

@allroundexperts
Copy link
Contributor

Hi @slafortune!
I get paid through the App. Can you just write the payment summary here for me and close the issue? Thank you!

@slafortune
Copy link
Contributor

Ah! @allroundexperts That crossed my mind, then I thought I was wrong and carried on! Thanks for the reminder, I should have looked!

@slafortune
Copy link
Contributor

@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Dec 5, 2023
@JmillsExpensify
Copy link

$250 payment approved for @allroundexperts based on summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Task Typescript Migration Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

5 participants