-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-11-07] [TS migration] Migrate 'PolicyUtils.js' lib to TypeScript #24867
Comments
This issue has not been updated in over 15 days. eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
Hey! I’m Bartosz from Software Mansion, an expert agency, and I’d like to work on this issue! |
Triggered auto assignment to @AndrewGable, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@AndrewGable Could you assign this to me and add the |
Triggered auto assignment to @isabelastisser ( |
Bug0 Triage Checklist (Main S/O)
|
Hey @AndrewGable @mollfpr, I'm not sure what the BZ team member is supposed to do here. Can you please clarify? Thanks! |
I think just payment once the PR is merged |
Triggered auto assignment to @twisterdotcom ( |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.93-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-11-07. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
I think there's we don't need a regression test for this migration. @isabelastisser Could you give us the payment summary so I can do the manual request? Thank you! |
I'm unsure about the payment amount, asking for clarification here. |
@AndrewGable any insight? |
Replied in Slack |
@mollfpr, the payment is $250; please proceed with the manual request. Thanks! |
$250 payment approved for @mollfpr based on comment above. |
TypeScript migration
Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.
Files
The text was updated successfully, but these errors were encountered: