Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-11-07] [TS migration] Migrate 'PolicyUtils.js' lib to TypeScript #24867

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/libs/PolicyUtils.js 5
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@BartoszGrajdek
Copy link
Contributor

Hey! I’m Bartosz from Software Mansion, an expert agency, and I’d like to work on this issue!

@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 2, 2023

Triggered auto assignment to @AndrewGable, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 18, 2023
@mollfpr
Copy link
Contributor

mollfpr commented Oct 25, 2023

@AndrewGable Could you assign this to me and add the Bug label? Thanks!

@AndrewGable AndrewGable added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 25, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 25, 2023

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 25, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 25, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@isabelastisser
Copy link
Contributor

Hey @AndrewGable @mollfpr, I'm not sure what the BZ team member is supposed to do here. Can you please clarify? Thanks!

@AndrewGable
Copy link
Contributor

I think just payment once the PR is merged

@roryabraham roryabraham added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Oct 26, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 26, 2023

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Oct 26, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 31, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'PolicyUtils.js' lib to TypeScript [HOLD for payment 2023-11-07] [TS migration] Migrate 'PolicyUtils.js' lib to TypeScript Oct 31, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 31, 2023
Copy link
Author

melvin-bot bot commented Oct 31, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Oct 31, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.93-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

Copy link
Author

melvin-bot bot commented Oct 31, 2023

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@mollfpr] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@mollfpr
Copy link
Contributor

mollfpr commented Nov 6, 2023

I think there's we don't need a regression test for this migration.

@isabelastisser Could you give us the payment summary so I can do the manual request? Thank you!

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 7, 2023
@isabelastisser
Copy link
Contributor

I'm unsure about the payment amount, asking for clarification here.

@isabelastisser
Copy link
Contributor

@AndrewGable any insight?

@AndrewGable
Copy link
Contributor

Replied in Slack

@isabelastisser
Copy link
Contributor

@mollfpr, the payment is $250; please proceed with the manual request. Thanks!

@JmillsExpensify
Copy link

$250 payment approved for @mollfpr based on comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Task Typescript Migration
Projects
Development

No branches or pull requests

7 participants