Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-11-06] [TS migration] Migrate 'SidebarUtils.js' lib to TypeScript #24915

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 19 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/libs/SidebarUtils.js 15
Issue OwnerCurrent Issue Owner: @CortneyOfstad
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@blazejkustra
Copy link
Contributor

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue!

@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 16, 2023

Triggered auto assignment to @bondydaa, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@Santhosh-Sellavel
Copy link
Collaborator

@bondydaa can you assign me here for review?

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 30, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'SidebarUtils.js' lib to TypeScript [HOLD for payment 2023-11-06] [TS migration] Migrate 'SidebarUtils.js' lib to TypeScript Oct 30, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 30, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 30, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 30, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.92-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@Santhosh-Sellavel
Copy link
Collaborator

@bondydaa please assign me here for Review

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Nov 5, 2023
Copy link
Author

melvin-bot bot commented Nov 8, 2023

@bondydaa, @blazejkustra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@Santhosh-Sellavel
Copy link
Collaborator

@bondydaa Can you assign a BZ here, also assign me here for review

@bondydaa bondydaa added Overdue Bug Something is broken. Auto assigns a BugZero manager. labels Nov 8, 2023
Copy link
Author

melvin-bot bot commented Nov 8, 2023

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot removed the Overdue label Nov 8, 2023

This comment was marked as outdated.

@bondydaa
Copy link
Contributor

bondydaa commented Nov 8, 2023

@CortneyOfstad can you payout @Santhosh-Sellavel for reviewing the PR on this.

@CortneyOfstad
Copy link
Contributor

@bondydaa can do! To confirm is this $500 and if so, did this also qualify for the bonus? Thanks!

@Santhosh-Sellavel
Copy link
Collaborator

Santhosh-Sellavel commented Nov 8, 2023

@CortneyOfstad No this doesn't qualify for a bonus, and payment for TS Migration is $250. Please leave a payment summary message I'll collect via New Dot thanks!

@melvin-bot melvin-bot bot added the Overdue label Nov 13, 2023
@CortneyOfstad
Copy link
Contributor

Sorry for the delay here @Santhosh-Sellavel!

Payment Summary

@Santhosh-Sellavel to be paid $250 for TS Migration via NewDot

@melvin-bot melvin-bot bot removed the Overdue label Nov 13, 2023
@CortneyOfstad
Copy link
Contributor

@Santhosh-Sellavel Is this ready to close? Or does it need to remain open until payment is completed in NewDot? TIA!

@CortneyOfstad
Copy link
Contributor

Bump @Santhosh-Sellavel ^^^ Thanks!

@Santhosh-Sellavel
Copy link
Collaborator

Feel free to close.

@JmillsExpensify
Copy link

$250 payment approved for @Santhosh-Sellavel based on summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Task Typescript Migration
Projects
Development

No branches or pull requests

5 participants