-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-02-07] [TS migration] Migrate 'OptionsListUtils.js' lib to TypeScript #24921
Comments
This issue has not been updated in over 15 days. eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
Hi, I'm Jakub from Callstack - expert contributor group - and I would like to take a look at this issue. |
@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing. If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead. |
Triggered auto assignment to @deetergp, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Triggered auto assignment to @JmillsExpensify ( |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-02-07. 🎊 |
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
There's regression which is not fixed yet. |
@situchan looks like it is not a deploy broker, i'll try to prepare a PR, but the issue has a proposal already wouldn't that be a problem? |
yup not blocker since it's minor. But just commenting as it's still within regression period. |
@getusha I think you can review #35541 @kubabutkiewicz raised |
Are any contributors due payment for this issue? It's not super clear to me. |
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO. |
@JmillsExpensify i should be paid since i reviewed the PR but should be after we fix a regression caused by this. |
@deetergp, @JmillsExpensify Huh... This is 4 days overdue. Who can take care of this? |
@getusha This is the regression fix you're referring to right? #35541 Should I assign you as the reviewer and unassign @DylanDylann? |
@deetergp yes please, thanks! |
Done! |
@getusha What's the status on the review for the regression fix? |
@deetergp will try to review today! |
TypeScript migration
Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.
Files
The text was updated successfully, but these errors were encountered: