Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-02-07] [TS migration] Migrate 'OptionsListUtils.js' lib to TypeScript #24921

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 22 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Not a priority Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/libs/OptionsListUtils.js 18
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@kubabutkiewicz
Copy link
Contributor

Hi, I'm Jakub from Callstack - expert contributor group - and I would like to take a look at this issue.

Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Copy link
Author

melvin-bot bot commented Jan 25, 2024

Triggered auto assignment to @deetergp, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added the NewFeature Something to build that is a new item. label Jan 25, 2024
Copy link
Author

melvin-bot bot commented Jan 25, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jan 26, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 31, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'OptionsListUtils.js' lib to TypeScript [HOLD for payment 2024-02-07] [TS migration] Migrate 'OptionsListUtils.js' lib to TypeScript Jan 31, 2024
Copy link
Author

melvin-bot bot commented Jan 31, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 31, 2024
Copy link
Author

melvin-bot bot commented Jan 31, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-07. 🎊

Copy link
Author

melvin-bot bot commented Jan 31, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@deetergp] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@situchan
Copy link
Contributor

There's regression which is not fixed yet.
cc: @kubabutkiewicz @getusha

@getusha
Copy link
Contributor

getusha commented Jan 31, 2024

@situchan looks like it is not a deploy broker, i'll try to prepare a PR, but the issue has a proposal already wouldn't that be a problem?

@situchan
Copy link
Contributor

yup not blocker since it's minor. But just commenting as it's still within regression period.

@kubabutkiewicz
Copy link
Contributor

@situchan @getusha Preparing PR for that

@situchan
Copy link
Contributor

situchan commented Feb 1, 2024

@situchan looks like it is not a deploy broker, i'll try to prepare a PR, but the issue has a proposal already wouldn't that be a problem?

@getusha I think you can review #35541 @kubabutkiewicz raised

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 6, 2024
@JmillsExpensify
Copy link

Are any contributors due payment for this issue? It's not super clear to me.

Copy link
Author

melvin-bot bot commented Feb 7, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@getusha
Copy link
Contributor

getusha commented Feb 7, 2024

@JmillsExpensify i should be paid since i reviewed the PR but should be after we fix a regression caused by this.
#35423

@melvin-bot melvin-bot bot added the Overdue label Feb 9, 2024
Copy link
Author

melvin-bot bot commented Feb 12, 2024

@deetergp, @JmillsExpensify Huh... This is 4 days overdue. Who can take care of this?

@deetergp
Copy link
Contributor

@getusha This is the regression fix you're referring to right? #35541 Should I assign you as the reviewer and unassign @DylanDylann?

@melvin-bot melvin-bot bot removed the Overdue label Feb 12, 2024
@getusha
Copy link
Contributor

getusha commented Feb 12, 2024

Should I assign you as the reviewer and unassign @DylanDylann?

@deetergp yes please, thanks!

@deetergp
Copy link
Contributor

Done!

@deetergp
Copy link
Contributor

@getusha What's the status on the review for the regression fix?

@getusha
Copy link
Contributor

getusha commented Feb 14, 2024

@deetergp will try to review today!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Not a priority Task Typescript Migration
Projects
Development

No branches or pull requests

5 participants