Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [TS migration] Migrate 'PopoverMenu' component to TypeScript #25096

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 21 comments
Closed

[$250] [TS migration] Migrate 'PopoverMenu' component to TypeScript #25096

melvin-bot bot opened this issue Aug 16, 2023 · 21 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Not a priority Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/PopoverMenu/popoverMenuPropTypes.js 2
src/components/PopoverMenu/index.js 15
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b7f8f0365a8ee53a
  • Upwork Job ID: 1747347260331507712
  • Last Price Increase: 2024-01-17
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 11, 2023
@VickyStash
Copy link
Contributor

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

@melvin-bot melvin-bot bot added the Overdue label Nov 13, 2023
@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Copy link
Author

melvin-bot bot commented Jan 3, 2024

Triggered auto assignment to @rlinoz, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@sobitneupane
Copy link
Contributor

@rlinoz This PR is ready for your final review.

@rlinoz
Copy link
Contributor

rlinoz commented Jan 5, 2024

@sobitneupane should I assign you to this issue since you did the code review?

@sobitneupane
Copy link
Contributor

Yes, please assign me to the issue. We can handle the payment details from here. Thank you!

@rlinoz rlinoz removed the Reviewing Has a PR in review label Jan 12, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 13, 2024
@rlinoz rlinoz added the External Added to denote the issue can be worked on by a contributor label Jan 16, 2024
Copy link
Author

melvin-bot bot commented Jan 16, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01b7f8f0365a8ee53a

@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'PopoverMenu' component to TypeScript [$500] [TS migration] Migrate 'PopoverMenu' component to TypeScript Jan 16, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 16, 2024
Copy link
Author

melvin-bot bot commented Jan 16, 2024

Current assignee @sobitneupane is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 Overdue labels Jan 16, 2024
@rlinoz rlinoz added Weekly KSv2 Overdue and removed Help Wanted Apply this label when an issue is open to proposals by contributors labels Jan 16, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jan 16, 2024
@allgandalf
Copy link
Contributor

Can i work on this issue?

@rlinoz rlinoz added Bug Something is broken. Auto assigns a BugZero manager. and removed External Added to denote the issue can be worked on by a contributor labels Jan 16, 2024
Copy link
Author

melvin-bot bot commented Jan 16, 2024

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Jan 16, 2024
@rlinoz
Copy link
Contributor

rlinoz commented Jan 16, 2024

This issue is actually done and merged, I was just checking which label would assign someone to pay @sobitneupane.

@conorpendergrast can you handle it?

@conorpendergrast
Copy link
Contributor

@rlinoz I can! The standard for these jobs is $250 IIRC. Is that correct?

@rlinoz
Copy link
Contributor

rlinoz commented Jan 16, 2024

Looking at other issues I believe you are correct!

@conorpendergrast conorpendergrast changed the title [$500] [TS migration] Migrate 'PopoverMenu' component to TypeScript [$250] [TS migration] Migrate 'PopoverMenu' component to TypeScript Jan 17, 2024
Copy link
Author

melvin-bot bot commented Jan 17, 2024

Upwork job price has been updated to $250

@conorpendergrast
Copy link
Contributor

Offer sent to @sobitneupane

@sobitneupane
Copy link
Contributor

@conorpendergrast I will request payment in newDot.

@conorpendergrast
Copy link
Contributor

Oops, yes, of course you will. Never mind me! I've withdrawn the Upwork offer now.

@conorpendergrast
Copy link
Contributor

Payouts due:

Contributor+: $250 @sobitneupane

Upwork job is here.

@conorpendergrast
Copy link
Contributor

All done here

@JmillsExpensify
Copy link

$250 approved for @sobitneupane based on summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Not a priority Task Typescript Migration
Projects
Development

No branches or pull requests

6 participants