Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-28] [TS migration] Migrate 'DeeplinkWrapper' component to TypeScript #25115

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Not a priority Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/DeeplinkWrapper/index.website.js 9
src/components/DeeplinkWrapper/index.js 1
src/components/DeeplinkWrapper/DeeplinkRedirectLoadingIndicator.js 11
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 11, 2023
@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@roryabraham roryabraham moved this from Done to Todo in Typescript migration Nov 29, 2023
@blazejkustra
Copy link
Contributor

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue!

Copy link
Author

melvin-bot bot commented Dec 14, 2023

Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 21, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'DeeplinkWrapper' component to TypeScript [HOLD for payment 2023-12-28] [TS migration] Migrate 'DeeplinkWrapper' component to TypeScript Dec 21, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 21, 2023
Copy link
Author

melvin-bot bot commented Dec 21, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Dec 21, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 27, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 29, 2023
Copy link
Author

melvin-bot bot commented Jan 1, 2024

@youssef-lr Huh... This is 4 days overdue. Who can take care of this?

Copy link
Author

melvin-bot bot commented Jan 1, 2024

@youssef-lr Eep! 4 days overdue now. Issues have feelings too...

@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Jan 2, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jan 2, 2024
@sobitneupane
Copy link
Contributor

@youssef-lr I reviewed the associated PR. Can you please assign the PR. I will require payment summary to request payment on newDot.

@JmillsExpensify
Copy link

Re-opening for the missing payment summary.

@sobitneupane
Copy link
Contributor

@youssef-lr I will also need payment summary for the request to get approved.

@youssef-lr
Copy link
Contributor

youssef-lr commented Feb 19, 2024

Payment summary

Contributor+: @sobitneupane owed $250 via NewDot.

The PR author and other reviewers are from an agency.

@JmillsExpensify
Copy link

$250 approved for @sobitneupane based on summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Not a priority Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests

4 participants