Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-02-07] [TS migration] Migrate 'ReportWelcomeMessage' page to TypeScript #25183

Closed
melvin-bot bot opened this issue Aug 17, 2023 · 15 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Not a priority Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/ReportWelcomeMessagePage.js 22
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@VickyStash
Copy link
Contributor

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

Copy link
Author

melvin-bot bot commented Jan 25, 2024

Triggered auto assignment to @Gonals, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added the NewFeature Something to build that is a new item. label Jan 30, 2024
Copy link
Author

melvin-bot bot commented Jan 30, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 31, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'ReportWelcomeMessage' page to TypeScript [HOLD for payment 2024-02-07] [TS migration] Migrate 'ReportWelcomeMessage' page to TypeScript Jan 31, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 31, 2024
Copy link
Author

melvin-bot bot commented Jan 31, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Jan 31, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-07. 🎊

Copy link
Author

melvin-bot bot commented Jan 31, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@Gonals] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@lschurr
Copy link
Contributor

lschurr commented Feb 5, 2024

Is there anyone who needs payment for this issue @Gonals? I think just @jjcoffee for reviewing the PR right?

@Gonals
Copy link
Contributor

Gonals commented Feb 7, 2024

Is there anyone who needs payment for this issue @Gonals? I think just @jjcoffee for reviewing the PR right?

I think so, yep

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 7, 2024
Copy link
Author

melvin-bot bot commented Feb 7, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@lschurr
Copy link
Contributor

lschurr commented Feb 7, 2024

Payment summary:

  • Contributor: @VickyStash is an agency-contributor and not due payment.
  • Contributor+: @jjcoffee $250 to be paid in Upwork

@lschurr
Copy link
Contributor

lschurr commented Feb 7, 2024

@jjcoffee
Copy link
Contributor

jjcoffee commented Feb 8, 2024

@lschurr Thanks, offer accepted!

@lschurr
Copy link
Contributor

lschurr commented Feb 8, 2024

Payment sent in Upwork. Closing this one out.

@lschurr lschurr closed this as completed Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Not a priority Task Typescript Migration
Projects
Development

No branches or pull requests

4 participants