-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Win / Chrome - Emoji flags are not displayed, only country codes #2521
Comments
Triggered auto assignment to @stephanieelliott ( |
Looks like this could be an incompatibility issue between Apple and Windows emojis, and not actually a bug with our implementation. @isagoico Was your screenshot taken from Chrome on a PC? |
Hello! Yes, it was taken from chrome/windows. I was also able to repro sending the emoji from android app to Windows chrome. |
@jasperhuangg just want to double check on this before posting for a contributor to pick up- do you think this is a bug that needs to be fixed, or is this an external compatibility issue that cannot be fixed on our side? |
@stephanieelliott Sorry for the late reply! I think it's an external compatibility issue. After a quick search, other people run into this issue on Windows as well. It appears that Microsoft has chosen not to support flags in their OS. I don't think this is something anyone can fix. I'd say there may be a solution involving parsing the Feel free to close this out, or ask another engineer for their opinion! |
Cool, thanks @jasperhuangg! Will go ahead and close this, if we feel this is valuable later down the line we can always reopen. |
@jasperhuangg @stephanieelliott We found this issue on the emoji picker too related to country flags in windows chrome. This one does look like an issue that should be fixed. Emojis - Country codes are displayed instead of corresponding flag emojisExpected ResultFor all the countries flags should appear Actual ResultOnly country codes are displayed instead of the flags Action Performed
PlatformWeb Windows/Chrome ✔️ Build: 1.0.36-0 Notes/Images/Video |
@stitesExpensify Looks like we need to check the user agent before constructing the Microsoft is trying way too hard to be PC by not including a single flag emoji 😭 I also wonder if this should be a priority at the moment though. Definitely something an external contributor could easily pick up and solve. @isagoico Do you mind opening up a new issue for this and triaging it? |
Yeah I think the solution would just be something like
|
@stitesExpensify Ah I guess flags are always going to be the last category |
Issue reproducible during today's KI retests |
@isagoico Were you able to create a new issue and triage it? |
Oh I'm so sorry I missed the previous request. Just created a new issue here #2761 |
Thanks @isagoico! Will go ahead and close this since we are not actioning this specific issue right now. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Expected Result:
USA flag sent from mweb Safari shows the same as in Web/Chrome
Actual Result:
USA flag sent from mweb Safari shows as "US" in Web/Chrome
Action Performed:
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platform:
Where is this issue occurring?
Web ✔️
iOS
Android
Desktop App
Mobile Web
Version Number: 1.0.28-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Expensify/Expensify Issue URL:
View all open jobs on Upwork
The text was updated successfully, but these errors were encountered: