Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win / Chrome - Emoji flags are not displayed, only country codes #2521

Closed
isagoico opened this issue Apr 21, 2021 · 14 comments
Closed

Win / Chrome - Emoji flags are not displayed, only country codes #2521

isagoico opened this issue Apr 21, 2021 · 14 comments
Assignees

Comments

@isagoico
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expected Result:

USA flag sent from mweb Safari shows the same as in Web/Chrome

Actual Result:

USA flag sent from mweb Safari shows as "US" in Web/Chrome

Action Performed:

  1. Go to https://staging.expensify.cash in mWeb Safari
  2. Click on any user (abeccivutest+1110@gmail.com) -Account B
  3. Click on emoji and find USA flag
  4. Send to Account B
  5. Log in Windows/Chrome and check messages

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

Web ✔️
iOS
Android
Desktop App
Mobile Web

Version Number: 1.0.28-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

image

Expensify/Expensify Issue URL:

View all open jobs on Upwork

@isagoico isagoico added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Apr 21, 2021
@MelvinBot
Copy link

Triggered auto assignment to @stephanieelliott (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Apr 21, 2021
@jasperhuangg
Copy link
Contributor

Looks like this could be an incompatibility issue between Apple and Windows emojis, and not actually a bug with our implementation. @isagoico Was your screenshot taken from Chrome on a PC?

@isagoico
Copy link
Author

isagoico commented Apr 22, 2021

Hello! Yes, it was taken from chrome/windows. I was also able to repro sending the emoji from android app to Windows chrome.

@stephanieelliott
Copy link
Contributor

@jasperhuangg just want to double check on this before posting for a contributor to pick up- do you think this is a bug that needs to be fixed, or is this an external compatibility issue that cannot be fixed on our side?

@jasperhuangg
Copy link
Contributor

jasperhuangg commented Apr 27, 2021

@stephanieelliott Sorry for the late reply!

I think it's an external compatibility issue. After a quick search, other people run into this issue on Windows as well. It appears that Microsoft has chosen not to support flags in their OS.

I don't think this is something anyone can fix. I'd say there may be a solution involving parsing the US characters and replacing them with an image, but there's no way to tell if the US characters were originally converted from an emoji, or if the person sending the message intended to just say US.

Feel free to close this out, or ask another engineer for their opinion!

@stephanieelliott
Copy link
Contributor

Cool, thanks @jasperhuangg! Will go ahead and close this, if we feel this is valuable later down the line we can always reopen.

@isagoico
Copy link
Author

isagoico commented May 4, 2021

@jasperhuangg @stephanieelliott

We found this issue on the emoji picker too related to country flags in windows chrome. This one does look like an issue that should be fixed.

Emojis - Country codes are displayed instead of corresponding flag emojis

Expected Result

For all the countries flags should appear

Actual Result

Only country codes are displayed instead of the flags

Action Performed

  1. Go to staging.expensify.cash and login
  2. Select any user and initiate chat
  3. In the text input field select emoji
  4. Search for "flag" in search field

Platform

Web Windows/Chrome ✔️

Build: 1.0.36-0

Notes/Images/Video

image

@isagoico isagoico reopened this May 4, 2021
@isagoico isagoico changed the title Emoji Flags sent from mobile are not displayed in Web/Chrome Win / Chrome - Emoji flags are not displayed, only country codes May 4, 2021
@jasperhuangg
Copy link
Contributor

@stitesExpensify Looks like we need to check the user agent before constructing the emoji array. Other than that, we'll also need to dynamically generate the header indices in the EmojiPickerMenu constructor. Should be as easy as iterating through it, but I wonder if it'll slow down each time we open the emoji picker later on when we add thousands of emojis (perhaps we can cache this?) 🤔

Microsoft is trying way too hard to be PC by not including a single flag emoji 😭

I also wonder if this should be a priority at the moment though. Definitely something an external contributor could easily pick up and solve. @isagoico Do you mind opening up a new issue for this and triaging it?

@stitesExpensify
Copy link
Contributor

Yeah I think the solution would just be something like

if (platform === windows) {
    emojis = emojis[0 - flagIndex];
    emojiHeaderIndices = [x,x,x,x,x] //(remove the last one for flags)
}

@jasperhuangg
Copy link
Contributor

@stitesExpensify Ah I guess flags are always going to be the last category

@isagoico
Copy link
Author

isagoico commented May 9, 2021

Issue reproducible during today's KI retests

@jasperhuangg
Copy link
Contributor

@isagoico Were you able to create a new issue and triage it?

@isagoico
Copy link
Author

Oh I'm so sorry I missed the previous request. Just created a new issue here #2761

@stephanieelliott
Copy link
Contributor

Thanks @isagoico! Will go ahead and close this since we are not actioning this specific issue right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants