Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-03-22] [TS migration] Migrate 'checkDeployBlockersTest.js' test to TypeScript #25298

Closed
melvin-bot bot opened this issue Aug 17, 2023 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Task Typescript Migration Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
tests/unit/checkDeployBlockersTest.js 4
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot reopened this Nov 23, 2023
Copy link
Author

melvin-bot bot commented Feb 5, 2024

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed Feb 5, 2024
@mountiny mountiny added NewFeature Something to build that is a new item. and removed Not a priority labels Feb 8, 2024
Copy link
Author

melvin-bot bot commented Feb 8, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Monthly KSv2 labels Feb 8, 2024
@mountiny mountiny reopened this Feb 8, 2024
@joekaufmanexpensify
Copy link
Contributor

@mountiny Does this already have someone working on it, or am I supposed to make this external and solicit a volunteer?

@mountiny
Copy link
Contributor

mountiny commented Feb 8, 2024

@joekaufmanexpensify Reopened so its not forgotten, @fabioh8010 and @blazejkustra will find someone to work on this

@joekaufmanexpensify
Copy link
Contributor

Got it. Are we working on these soon? More so just curious if I should stay assigned for now.

@mountiny mountiny added Monthly KSv2 and removed Weekly KSv2 labels Feb 9, 2024
@mountiny
Copy link
Contributor

mountiny commented Feb 9, 2024

yes please stay assigned just so it does not fall through the cracks again, made this monthly, they will get someone on this

@ruben-rebelo
Copy link
Contributor

I am Ruben Rebelo from Callstack - expert contributor group. I’d like to work on this job.

@joekaufmanexpensify
Copy link
Contributor

Sounds great. Assigned!

@joekaufmanexpensify
Copy link
Contributor

PR is WIP

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Mar 4, 2024
Copy link
Author

melvin-bot bot commented Mar 4, 2024

Triggered auto assignment to @NikkiWines, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@joekaufmanexpensify
Copy link
Contributor

@ruben-rebelo looks like some comments in the PR, can you address this week?

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 15, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'checkDeployBlockersTest.js' test to TypeScript [HOLD for payment 2024-03-22] [TS migration] Migrate 'checkDeployBlockersTest.js' test to TypeScript Mar 15, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 15, 2024
Copy link
Author

melvin-bot bot commented Mar 15, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Mar 15, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.52-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-22. 🎊

For reference, here are some details about the assignees on this issue:

Copy link
Author

melvin-bot bot commented Mar 15, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@ruben-rebelo] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@joekaufmanexpensify
Copy link
Contributor

TS migration. No payment needed here. All set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Task Typescript Migration Weekly KSv2
Projects
Development

No branches or pull requests

4 participants