Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-03-20] [TS migration] Migrate 'testRunner.js' test to TypeScript #25329

Closed
melvin-bot bot opened this issue Aug 17, 2023 · 15 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Help Wanted Apply this label when an issue is open to proposals by contributors NewFeature Something to build that is a new item. Task Typescript Migration Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
tests/e2e/testRunner.js 21
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018633152fd5e12df2
  • Upwork Job ID: 1757760252797624320
  • Last Price Increase: 2024-02-14
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@melvin-bot melvin-bot bot closed this as completed Feb 5, 2024
Copy link
Author

melvin-bot bot commented Feb 5, 2024

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@mountiny mountiny added NewFeature Something to build that is a new item. and removed Not a priority labels Feb 8, 2024
Copy link
Author

melvin-bot bot commented Feb 8, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Monthly KSv2 labels Feb 8, 2024
@mountiny mountiny reopened this Feb 8, 2024
@CortneyOfstad CortneyOfstad added External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Feb 14, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'testRunner.js' test to TypeScript [$500] [TS migration] Migrate 'testRunner.js' test to TypeScript Feb 14, 2024
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 14, 2024
@CortneyOfstad CortneyOfstad changed the title [$500] [TS migration] Migrate 'testRunner.js' test to TypeScript [$250] [TS migration] Migrate 'testRunner.js' test to TypeScript Feb 14, 2024
@CortneyOfstad CortneyOfstad added Monthly KSv2 and removed External Added to denote the issue can be worked on by a contributor Daily KSv2 labels Feb 14, 2024
@Expensify Expensify deleted a comment from melvin-bot bot Feb 14, 2024
@CortneyOfstad
Copy link
Contributor

Thanks for the proposal @hkopser99, but we actually have some teams working on these types of issues. Thanks for your interest though!

@CortneyOfstad CortneyOfstad added Weekly KSv2 Monthly KSv2 and removed Daily KSv2 Weekly KSv2 labels Feb 23, 2024
@JKobrynski
Copy link
Contributor

Hi, I'm Julian from Callstack - expert contributor group - and I would like to take a look at this issue.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 28, 2024
@CortneyOfstad CortneyOfstad added Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2 and removed Monthly KSv2 labels Feb 28, 2024
@CortneyOfstad
Copy link
Contributor

Sounds good — thanks @JKobrynski!

@JKobrynski
Copy link
Contributor

The PR is ready for review!

Copy link
Author

melvin-bot bot commented Mar 7, 2024

Triggered auto assignment to @arosiclair, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@CortneyOfstad
Copy link
Contributor

PR had adjustments made a few hours ago, and looking good! 👍

@arosiclair
Copy link
Contributor

Just merged. This should be all set

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 13, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'testRunner.js' test to TypeScript [HOLD for payment 2024-03-20] [TS migration] Migrate 'testRunner.js' test to TypeScript Mar 13, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 13, 2024
Copy link
Author

melvin-bot bot commented Mar 13, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Mar 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-20. 🎊

For reference, here are some details about the assignees on this issue:

Copy link
Author

melvin-bot bot commented Mar 13, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@JKobrynski] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Help Wanted Apply this label when an issue is open to proposals by contributors NewFeature Something to build that is a new item. Task Typescript Migration Weekly KSv2
Projects
Development

No branches or pull requests

6 participants