Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-04-15] [TS migration] Migrate 'versionUpdater.js' .github file to TypeScript #25363

Closed
melvin-bot bot opened this issue Aug 17, 2023 · 12 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Not a priority Reviewing Has a PR in review Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
.github/libs/versionUpdater.js 1
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@melvin-bot melvin-bot bot closed this as completed Feb 5, 2024
Copy link
Author

melvin-bot bot commented Feb 5, 2024

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot reopened this Feb 9, 2024
@kubabutkiewicz
Copy link
Contributor

Hi, I'm Jakub from Callstack - expert contributor group - and I would like to take a look at this issue.

@kubabutkiewicz
Copy link
Contributor

Hi, will be ooo next week , will that care of that when I come back

@melvin-bot melvin-bot bot added the Overdue label Mar 15, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 NewFeature Something to build that is a new item. and removed Monthly KSv2 Overdue labels Apr 2, 2024
Copy link
Author

melvin-bot bot commented Apr 3, 2024

@stephanieelliott
Copy link
Contributor

Hey @kubabutkiewicz have you gotten a chance to take a look at this one? I've assigned you based on your comment

@kubabutkiewicz
Copy link
Contributor

@stephanieelliott issue is resolved and merged to main

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Apr 8, 2024
@melvin-bot melvin-bot bot added the Awaiting Payment Auto-added when associated PR is deployed to production label Apr 8, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'versionUpdater.js' .github file to TypeScript [HOLD for payment 2024-04-15] [TS migration] Migrate 'versionUpdater.js' .github file to TypeScript Apr 8, 2024
Copy link
Author

melvin-bot bot commented Apr 8, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 8, 2024
Copy link
Author

melvin-bot bot commented Apr 8, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-15. 🎊

For reference, here are some details about the assignees on this issue:

Copy link
Author

melvin-bot bot commented Apr 8, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@kubabutkiewicz] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Daily KSv2 and removed Weekly KSv2 labels Apr 8, 2024
Copy link
Author

melvin-bot bot commented Apr 15, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@stephanieelliott
Copy link
Contributor

No payment due here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Not a priority Reviewing Has a PR in review Task Typescript Migration
Projects
Development

No branches or pull requests

2 participants